From: Ryan Arnold <ryanarn@us.ibm.com>
To: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
Cc: Michael Neuling <mikey@neuling.org>,
Michael R Meissner <mrmeissn@us.ibm.com>,
Steve Munroe <sjmunroe@us.ibm.com>,
Peter Bergner <bergner@us.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/4] powerpc/cputable: reserve bits in HWCAP2 for new features
Date: Mon, 6 May 2013 14:07:23 -0500 [thread overview]
Message-ID: <OFA8304853.25190807-ON86257B63.0067EDA3-86257B63.00690C34@us.ibm.com> (raw)
In-Reply-To: <20130504004756.GA3532@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
Hi Nish,
Nishanth Aravamudan <nacc@linux.vnet.ibm.com> wrote on 05/03/2013 07:47:56
PM:
> +/* in AT_HWCAP2 */
> +#define PPC_FEATURE2_ARCH_2_07 0x80000000
> +#define PPC_FEATURE2_HTM 0x40000000
> +#define PPC_FEATURE2_DSCR 0x20000000
> +#define PPC_FEATURE2_EBB 0x10000000
> +#define PPC_FEATURE2_ISEL 0x08000000
> +#define PPC_FEATURE2_TAR 0x04000000
> +
> #endif /* _UAPI__ASM_POWERPC_CPUTABLE_H */
Following the existing naming convention in cputable.h, the features should
probably be amended to the following:
#define PPC_FEATURE2_ARCH_2_07 0x80000000
#define PPC_FEATURE2_HAS_HTM 0x40000000
#define PPC_FEATURE2_HAS_DSC 0x20000000
#define PPC_FEATURE2_HAS_EBB 0x10000000
#define PPC_FEATURE2_HAS_ISEL 0x08000000
#define PPC_FEATURE2_HAS_TAR 0x04000000
Notice that I changed DSCR to DSC. The 'R' wasn't descriptive.
Ryan S. Arnold
IBM Linux Technology Center
[-- Attachment #2: Type: text/html, Size: 1690 bytes --]
next prev parent reply other threads:[~2013-05-06 19:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 23:19 [PATCH] arch/powerpc: advertise ISA2.07, HTM, DSCR, EBB and ISEL bits in HWCAP2 Nishanth Aravamudan
2013-05-03 23:23 ` Benjamin Herrenschmidt
2013-05-03 23:40 ` Nishanth Aravamudan
2013-05-06 14:38 ` Ryan Arnold
2013-05-06 21:37 ` Benjamin Herrenschmidt
2013-05-07 15:11 ` Ryan Arnold
2013-05-07 20:33 ` Nishanth Aravamudan
2013-05-07 20:49 ` Benjamin Herrenschmidt
2013-05-07 21:11 ` Nishanth Aravamudan
2013-05-03 23:26 ` Michael R Meissner
2013-05-04 21:42 ` Segher Boessenkool
2013-05-04 0:04 ` Michael Neuling
2013-05-04 0:47 ` [PATCH v2 1/4] powerpc/cputable: reserve bits in HWCAP2 for new features Nishanth Aravamudan
2013-05-04 0:48 ` [PATCH v2 2/4] powerpc/cputable: advertise DSCR support on P7/P7+ Nishanth Aravamudan
2013-05-04 0:49 ` [PATCH v2 3/4] powerpc/cputable: advertise ISEL support on appropriate embedded processors Nishanth Aravamudan
2013-05-04 0:49 ` [PATCH v2 4/4] powerpc/cputable: advertise support for ISEL/HTM/DSCR/TAR on POWER8 Nishanth Aravamudan
2013-05-05 2:01 ` [PATCH v3 3/4] powerpc/cputable: advertise ISEL support on appropriate embedded processors Nishanth Aravamudan
2013-05-20 15:04 ` [PATCH v2 2/4] powerpc/cputable: advertise DSCR support on P7/P7+ Will Schmidt
2013-05-20 23:41 ` Michael Neuling
2013-05-06 19:07 ` Ryan Arnold [this message]
2013-05-06 21:41 ` [PATCH v2 1/4] powerpc/cputable: reserve bits in HWCAP2 for new features Benjamin Herrenschmidt
2013-05-07 15:07 ` Ryan Arnold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OFA8304853.25190807-ON86257B63.0067EDA3-86257B63.00690C34@us.ibm.com \
--to=ryanarn@us.ibm.com \
--cc=bergner@us.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mrmeissn@us.ibm.com \
--cc=nacc@linux.vnet.ibm.com \
--cc=sjmunroe@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).