From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Scott Wood <scottwood@freescale.com>,
Michael Weiser <michael@weiser.dinsnail.net>
Cc: "Rogério Brito" <rbrito@ime.usp.br>, linuxppc-dev@ozlabs.org
Subject: [PATCH] fix i2c on PPC linkstation / kurobox machines
Date: Fri, 24 Oct 2008 01:05:56 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0810240059170.9657@axis700.grange> (raw)
In-Reply-To: <20081023213309.GA19777@weiser.dinsnail.net>
i2c is broken on linkstation / kurobox machines since at least 2.6.27. Fix
it. Also remove CONFIG_SERIAL_OF_PLATFORM, which, if enabled, breaks the
serial console after the "console handover: boot [udbg0] -> real [ttyS1]"
message.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
No, I do not really understand why I have to remove
CONFIG_SERIAL_OF_PLATFORM now after adding a call to
of_platform_bus_probe(), but it works this way. It must have something to
do with the legacy serial driver... If accepted in this form, I'll also
forward it to stable.
diff --git a/arch/powerpc/configs/linkstation_defconfig b/arch/powerpc/configs/linkstation_defconfig
index 6fc4c21..d0846ec 100644
--- a/arch/powerpc/configs/linkstation_defconfig
+++ b/arch/powerpc/configs/linkstation_defconfig
@@ -1,7 +1,7 @@
#
# Automatically generated make config: don't edit
-# Linux kernel version: 2.6.27-rc4
-# Thu Aug 21 00:52:05 2008
+# Linux kernel version: 2.6.27
+# Fri Oct 24 00:42:39 2008
#
# CONFIG_PPC64 is not set
@@ -934,7 +934,7 @@ CONFIG_SERIAL_8250_RUNTIME_UARTS=4
CONFIG_SERIAL_CORE=y
CONFIG_SERIAL_CORE_CONSOLE=y
# CONFIG_SERIAL_JSM is not set
-CONFIG_SERIAL_OF_PLATFORM=y
+# CONFIG_SERIAL_OF_PLATFORM is not set
CONFIG_UNIX98_PTYS=y
CONFIG_LEGACY_PTYS=y
CONFIG_LEGACY_PTY_COUNT=256
@@ -1211,7 +1211,6 @@ CONFIG_USB_STORAGE=m
# CONFIG_USB_STORAGE_ALAUDA is not set
# CONFIG_USB_STORAGE_ONETOUCH is not set
# CONFIG_USB_STORAGE_KARMA is not set
-# CONFIG_USB_STORAGE_SIERRA is not set
# CONFIG_USB_STORAGE_CYPRESS_ATACB is not set
# CONFIG_USB_LIBUSUAL is not set
diff --git a/arch/powerpc/platforms/embedded6xx/linkstation.c b/arch/powerpc/platforms/embedded6xx/linkstation.c
index eb5d74e..2ca7be6 100644
--- a/arch/powerpc/platforms/embedded6xx/linkstation.c
+++ b/arch/powerpc/platforms/embedded6xx/linkstation.c
@@ -13,6 +13,7 @@
#include <linux/kernel.h>
#include <linux/initrd.h>
#include <linux/mtd/physmap.h>
+#include <linux/of_platform.h>
#include <asm/time.h>
#include <asm/prom.h>
@@ -54,6 +55,19 @@ static struct mtd_partition linkstation_physmap_partitions[] = {
},
};
+static __initdata struct of_device_id of_bus_ids[] = {
+ { .type = "soc", },
+ { .compatible = "simple-bus", },
+ {},
+};
+
+static int __init declare_of_platform_devices(void)
+{
+ of_platform_bus_probe(NULL, of_bus_ids, NULL);
+ return 0;
+}
+machine_device_initcall(linkstation, declare_of_platform_devices);
+
static int __init linkstation_add_bridge(struct device_node *dev)
{
#ifdef CONFIG_PCI
next parent reply other threads:[~2008-10-23 23:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081022191650.GA11406@weiser.dinsnail.net>
[not found] ` <Pine.LNX.4.64.0810232029380.9657@axis700.grange>
[not found] ` <20081023213309.GA19777@weiser.dinsnail.net>
2008-10-23 23:05 ` Guennadi Liakhovetski [this message]
2008-10-24 0:19 ` [PATCH] fix i2c on PPC linkstation / kurobox machines Benjamin Herrenschmidt
2008-10-24 18:25 ` Guennadi Liakhovetski
2008-10-28 13:58 ` Kumar Gala
2008-10-28 14:06 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0810240059170.9657@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@weiser.dinsnail.net \
--cc=rbrito@ime.usp.br \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).