From: Michael Kelley <mhklinux@outlook.com>
To: Baoquan He <bhe@redhat.com>
Cc: "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nathan@kernel.org" <nathan@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH linux-next 1/3] x86, crash: don't nest CONFIG_CRASH_DUMP ifdef inside CONFIG_KEXEC_CODE ifdef scope
Date: Tue, 30 Jan 2024 01:39:39 +0000 [thread overview]
Message-ID: <SN6PR02MB41575A5568875B85C8AA7F4BD47D2@SN6PR02MB4157.namprd02.prod.outlook.com> (raw)
In-Reply-To: <ZbhH+sg1BPi+R0j4@MiWiFi-R3L-srv>
From: Baoquan He <bhe@redhat.com>
>
> On 01/29/24 at 06:27pm, Michael Kelley wrote:
> > From: Baoquan He <bhe@redhat.com> Sent: Monday, January 29, 2024
> 5:51 AM
> > >
> > > Michael pointed out that the #ifdef CONFIG_CRASH_DUMP is nested inside
> > > arch/x86/xen/enlighten_hvm.c.
> >
> > Did some words get left out in the above sentence? It mentions the Xen
> > case, but not the Hyper-V case. I'm not sure what you intended.
>
> Thanks a lot for your careful reviewing.
>
> Yeah, I tried to list all affected file names, seems my vim editor threw
> away some words. And I forgot mentioning the change in reboot.c.
>
> I adjusted log as below according to your comments, do you think it's OK
> now?
Yes -- looks like everything is included and clear up my confusion. But
I still have two small nits per below. :-)
Michael
>
> ===
> Michael pointed out that the #ifdef CONFIG_CRASH_DUMP is nested inside
> CONFIG_KEXEC_CODE ifdef scope in some XEN, HyperV codes.
s/Hyper-V/HyperV/
>
> Although the nesting works well too since CONFIG_CRASH_DUMP has
> dependency on CONFIG_KEXEC_CORE, it may cause confusion because there
> are places where it's not nested, and people may think it needs be nested
s/needs to be/needs be/
> even though it doesn't have to.
>
> Fix that by moving CONFIG_CRASH_DUMP ifdeffery of codes out of
> CONFIG_KEXEC_CODE ifdeffery scope.
>
> And also put function machine_crash_shutdown() definition inside
> CONFIG_CRASH_DUMP ifdef scope instead of CONFIG_KEXEC_CORE ifdef.
>
> And also fix a building error Nathan reported as below by replacing
> CONFIG_KEXEC_CORE ifdef with CONFIG_VMCORE_INFO ifdef.
> ......
> ===
>
> Thanks
> Baoquan
next prev parent reply other threads:[~2024-01-30 1:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 13:50 [PATCH linux-next 1/3] x86, crash: don't nest CONFIG_CRASH_DUMP ifdef inside CONFIG_KEXEC_CODE ifdef scope Baoquan He
2024-01-29 13:50 ` [PATCH linux-next 2/3] crash: fix building error in generic codes Baoquan He
2024-01-29 13:50 ` [PATCH linux-next 3/3] arch, crash: move arch_crash_save_vmcoreinfo() out to file vmcore_info.c Baoquan He
2024-01-29 18:27 ` [PATCH linux-next 1/3] x86, crash: don't nest CONFIG_CRASH_DUMP ifdef inside CONFIG_KEXEC_CODE ifdef scope Michael Kelley
2024-01-30 0:51 ` Baoquan He
2024-01-30 1:39 ` Michael Kelley [this message]
2024-01-30 3:58 ` Baoquan He
2024-01-30 2:59 ` [PATCH v2 " Baoquan He
2024-01-30 5:36 ` Michael Kelley
2024-02-03 0:17 ` [PATCH " Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR02MB41575A5568875B85C8AA7F4BD47D2@SN6PR02MB4157.namprd02.prod.outlook.com \
--to=mhklinux@outlook.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nathan@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).