Re: [PATCH v10 7/8] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers

From: Niklas Cassel <cassel@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
	linux-pci@vger.kernel.org,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Minghuan Lian" <minghuan.Lian@nxp.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Marek Vasut" <marek.vasut+renesas@gmail.com>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Jesper Nilsson" <jesper.nilsson@axis.com>,
	linux-tegra@vger.kernel.org, linux-arm-kernel@axis.com,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Richard Zhu" <hongxing.zhu@nxp.com>,
	"Srikanth Thokala" <srikanth.thokala@intel.com>,
	linux-arm-msm@vger.kernel.org,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	linuxppc-dev@lists.ozlabs.org,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	linux-omap@vger.kernel.org, "Mingkai Hu" <mingkai.hu@nxp.com>,
	linux-arm-kernel@lists.infradead.org,
	"Roy Zang" <roy.zang@nxp.com>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
	linux-kernel@vger.kernel.org, "Vidya Sagar" <vidyas@nvidia.com>,
	linux-renesas-soc@vger.kernel.org,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Lucas Stach" <l.stach@pengutronix.de>
Subject: Re: [PATCH v10 7/8] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers
Date: Fri, 22 Mar 2024 12:03:07 +0100	[thread overview]
Message-ID: <Zf1la9ICDCHAyOit@ryzen> (raw)
In-Reply-To: <20240314-pci-dbi-rework-v10-7-14a45c5a938e@linaro.org>

On Thu, Mar 14, 2024 at 01:18:05PM +0530, Manivannan Sadhasivam wrote:
> Currently, dw_pcie_ep_init_registers() API is directly called by the glue
> drivers requiring active refclk from host. But for the other drivers, it is
> getting called implicitly by dw_pcie_ep_init(). This is due to the fact
> that this API initializes DWC EP specific registers and that requires an
> active refclk (either from host or generated locally by endpoint itsef).
> 
> But, this causes a discrepancy among the glue drivers. So to avoid this
> confusion, let's call this API directly from all glue drivers irrespective
> of refclk dependency. Only difference here is that the drivers requiring
> refclk from host will call this API only after the refclk is received and
> other drivers without refclk dependency will call this API right after
> dw_pcie_ep_init().
> 
> With this change, the check for 'core_init_notifier' flag can now be
> dropped from dw_pcie_ep_init() API. This will also allow us to remove the
> 'core_init_notifier' flag completely in the later commits.
> 
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---

Reviewed-by: Niklas Cassel <cassel@kernel.org>