From: Baoquan He <bhe@redhat.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] mm/mm_init.c: remove unneeded calc_memmap_size()
Date: Thu, 28 Mar 2024 09:24:01 +0800 [thread overview]
Message-ID: <ZgTGsY/nQlKZd8jh@MiWiFi-R3L-srv> (raw)
In-Reply-To: <ZgRHgL1zbQc2DJlc@kernel.org>
On 03/27/24 at 06:21pm, Mike Rapoport wrote:
> On Mon, Mar 25, 2024 at 10:56:45PM +0800, Baoquan He wrote:
> > Nobody calls calc_memmap_size() now.
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
>
> Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>
>
> Looks like I replied to patch 6/6 twice by mistake and missed this one.
Thanks for your careful reviewing.
>
> > ---
> > mm/mm_init.c | 20 --------------------
> > 1 file changed, 20 deletions(-)
> >
> > diff --git a/mm/mm_init.c b/mm/mm_init.c
> > index 7f71e56e83f3..e269a724f70e 100644
> > --- a/mm/mm_init.c
> > +++ b/mm/mm_init.c
> > @@ -1331,26 +1331,6 @@ static void __init calculate_node_totalpages(struct pglist_data *pgdat,
> > pr_debug("On node %d totalpages: %lu\n", pgdat->node_id, realtotalpages);
> > }
> >
> > -static unsigned long __init calc_memmap_size(unsigned long spanned_pages,
> > - unsigned long present_pages)
> > -{
> > - unsigned long pages = spanned_pages;
> > -
> > - /*
> > - * Provide a more accurate estimation if there are holes within
> > - * the zone and SPARSEMEM is in use. If there are holes within the
> > - * zone, each populated memory region may cost us one or two extra
> > - * memmap pages due to alignment because memmap pages for each
> > - * populated regions may not be naturally aligned on page boundary.
> > - * So the (present_pages >> 4) heuristic is a tradeoff for that.
> > - */
> > - if (spanned_pages > present_pages + (present_pages >> 4) &&
> > - IS_ENABLED(CONFIG_SPARSEMEM))
> > - pages = present_pages;
> > -
> > - return PAGE_ALIGN(pages * sizeof(struct page)) >> PAGE_SHIFT;
> > -}
> > -
> > #ifdef CONFIG_TRANSPARENT_HUGEPAGE
> > static void pgdat_init_split_queue(struct pglist_data *pgdat)
> > {
> > --
> > 2.41.0
> >
>
> --
> Sincerely yours,
> Mike.
>
next prev parent reply other threads:[~2024-03-28 1:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 14:56 [PATCH v2 0/6] mm/mm_init.c: refactor free_area_init_core() Baoquan He
2024-03-25 14:56 ` [PATCH v2 1/6] x86: remove unneeded memblock_find_dma_reserve() Baoquan He
2024-03-26 6:44 ` Mike Rapoport
2024-03-25 14:56 ` [PATCH v2 2/6] mm/mm_init.c: remove the useless dma_reserve Baoquan He
2024-03-26 6:44 ` Mike Rapoport
2024-03-25 14:56 ` [PATCH v2 3/6] mm/mm_init.c: add new function calc_nr_all_pages() Baoquan He
2024-03-26 6:57 ` Mike Rapoport
2024-03-26 13:49 ` Baoquan He
2024-03-27 15:40 ` Mike Rapoport
2024-03-25 14:56 ` [PATCH v2 4/6] mm/mm_init.c: remove meaningless calculation of zone->managed_pages in free_area_init_core() Baoquan He
2024-03-27 15:40 ` Mike Rapoport
2024-03-28 8:32 ` Baoquan He
2024-03-28 9:53 ` Mike Rapoport
2024-03-28 14:46 ` Baoquan He
2024-03-28 9:12 ` [PATCH v3 " Baoquan He
2024-03-25 14:56 ` [PATCH v2 5/6] mm/mm_init.c: remove unneeded calc_memmap_size() Baoquan He
2024-03-27 16:21 ` Mike Rapoport
2024-03-28 1:24 ` Baoquan He [this message]
2024-03-25 14:56 ` [PATCH v2 6/6] mm/mm_init.c: remove arch_reserved_kernel_pages() Baoquan He
2024-03-26 6:57 ` Mike Rapoport
2024-03-27 15:41 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgTGsY/nQlKZd8jh@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rppt@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).