From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Michael Neuling <mikey@neuling.org>,
Daniel Axtens <dja@axtens.net>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linuxppc-dev@lists.ozlabs.org, kasan-dev@googlegroups.com,
aneesh.kumar@linux.ibm.com, bsingharora@gmail.com
Subject: Re: [PATCH v7 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support
Date: Mon, 17 Feb 2020 07:45:46 +0100 [thread overview]
Message-ID: <a060e08e-c119-0d37-d220-409b3d7539d3@c-s.fr> (raw)
In-Reply-To: <66bd9d8eb682cda2d22bea0fd4035ea8e0a3c1fb.camel@neuling.org>
Le 17/02/2020 à 00:08, Michael Neuling a écrit :
> Daniel.
>
> Can you start this commit message with a simple description of what you are
> actually doing? This reads like you've been on a long journey to Mordor and
> back, which as a reader of this patch in the long distant future, I don't care
> about. I just want to know what you're implementing.
>
> Also I'm struggling to review this as I don't know what software or hardware
> mechanisms you are using to perform sanitisation.
KASAN is standard, it's simply using GCC ASAN in kernel mode, ie kernel
is built with -fsanitize=kernel-address
(https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html)
You have more details there:
https://www.kernel.org/doc/html/latest/dev-tools/kasan.html
Christophe
prev parent reply other threads:[~2020-02-17 6:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 0:47 [PATCH v7 0/4] KASAN for powerpc64 radix Daniel Axtens
2020-02-13 0:47 ` [PATCH v7 1/4] kasan: define and use MAX_PTRS_PER_* for early shadow tables Daniel Axtens
2020-02-13 0:47 ` [PATCH v7 2/4] kasan: Document support on 32-bit powerpc Daniel Axtens
2020-02-13 0:47 ` [PATCH v7 3/4] powerpc/mm/kasan: rename kasan_init_32.c to init_32.c Daniel Axtens
2020-02-13 0:47 ` [PATCH v7 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support Daniel Axtens
2020-02-13 6:08 ` Christophe Leroy
2020-02-13 11:36 ` Christophe Leroy
2020-03-06 13:09 ` Daniel Axtens
2020-02-16 23:08 ` Michael Neuling
2020-02-17 6:45 ` Christophe Leroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a060e08e-c119-0d37-d220-409b3d7539d3@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=aneesh.kumar@linux.ibm.com \
--cc=bsingharora@gmail.com \
--cc=dja@axtens.net \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).