From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2CE0FA372C for ; Fri, 8 Nov 2019 07:26:01 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F0F620865 for ; Fri, 8 Nov 2019 07:26:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WyKjvmaQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F0F620865 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 478Wyv0lDBzF6pV for ; Fri, 8 Nov 2019 18:25:59 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=205.139.110.61; helo=us-smtp-1.mimecast.com; envelope-from=david@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="WyKjvmaQ"; dkim-atps=neutral Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 478Wkp4g7mzF25y for ; Fri, 8 Nov 2019 18:15:30 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573197327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PenExAfVRFXeBme8mP2F3ZJCJQhOeL0zIxQnZAXCsUI=; b=WyKjvmaQi0DWrmJoptM/3/AQBbRc2jRhq+jm93Pkzy6H7WLGUmztSEVd3NS7cvqCl6olVK VI019Z4UVpBZ7MS/j7ssStWFTEMAsSAfiyovg+zPQBfLCi0iTdvmNWrPagXaVxvAatU5UJ VTcsDdgNhUpEXnt1YToYf1oZk243qyM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-2-RVLOufnuOY2lPex8TZ9HIg-1; Fri, 08 Nov 2019 02:15:25 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 864E1800C72; Fri, 8 Nov 2019 07:15:18 +0000 (UTC) Received: from [10.36.116.108] (ovpn-116-108.ams2.redhat.com [10.36.116.108]) by smtp.corp.redhat.com (Postfix) with ESMTP id BDC1A5DA70; Fri, 8 Nov 2019 07:14:57 +0000 (UTC) Subject: Re: [PATCH v1 04/10] vfio/type1: Prepare is_invalid_reserved_pfn() for PG_reserved changes To: Dan Williams , Michal Hocko References: <0eb001e0-bb26-59bb-c514-d2f8a86a7eab@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Fri, 8 Nov 2019 08:14:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: RVLOufnuOY2lPex8TZ9HIg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Fri, 08 Nov 2019 18:23:55 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, Michal Hocko , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , KVM list , Pavel Tatashin , KarimAllah Ahmed , Dave Hansen , Alexander Duyck , Linux MM , Paolo Bonzini , Paul Mackerras , "H. Peter Anvin" , Wanpeng Li , Alexander Duyck , "K. Y. Srinivasan" , Thomas Gleixner , Kees Cook , devel@driverdev.osuosl.org, Stefano Stabellini , Stephen Hemminger , "Aneesh Kumar K.V" , Joerg Roedel , X86 ML , YueHaibing , "Matthew Wilcox \(Oracle\)" , Mike Rapoport , Peter Zijlstra , Ingo Molnar , Vlastimil Babka , Anthony Yznaga , Oscar Salvador , "Isaac J. Manjarres" , Matt Sickler , Juergen Gross , Anshuman Khandual , Haiyang Zhang , Sasha Levin , kvm-ppc@vger.kernel.org, Qian Cai , Alex Williamson , Mike Rapoport , David Hildenbrand , Nicholas Piggin , Andy Lutomirski , xen-devel , Boris Ostrovsky , Vitaly Kuznetsov , Allison Randal , Jim Mattson , Mel Gorman , Cornelia Huck , Pavel Tatashin , Linux Kernel Mailing List , Sean Christopherson , Johannes Weiner , Borislav Petkov , Andrew Morton , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 08.11.19 06:09, Dan Williams wrote: > On Thu, Nov 7, 2019 at 2:07 PM David Hildenbrand wrote= : >> >> On 07.11.19 19:22, David Hildenbrand wrote: >>> >>> >>>> Am 07.11.2019 um 16:40 schrieb Dan Williams = : >>>> >>>> =EF=BB=BFOn Thu, Oct 24, 2019 at 5:12 AM David Hildenbrand wrote: >>>>> >>>>> Right now, ZONE_DEVICE memory is always set PG_reserved. We want to >>>>> change that. >>>>> >>>>> KVM has this weird use case that you can map anything from /dev/mem >>>>> into the guest. pfn_valid() is not a reliable check whether the memma= p >>>>> was initialized and can be touched. pfn_to_online_page() makes sure >>>>> that we have an initialized memmap (and don't have ZONE_DEVICE memory= ). >>>>> >>>>> Rewrite is_invalid_reserved_pfn() similar to kvm_is_reserved_pfn() to= make >>>>> sure the function produces the same result once we stop setting ZONE_= DEVICE >>>>> pages PG_reserved. >>>>> >>>>> Cc: Alex Williamson >>>>> Cc: Cornelia Huck >>>>> Signed-off-by: David Hildenbrand >>>>> --- >>>>> drivers/vfio/vfio_iommu_type1.c | 10 ++++++++-- >>>>> 1 file changed, 8 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iomm= u_type1.c >>>>> index 2ada8e6cdb88..f8ce8c408ba8 100644 >>>>> --- a/drivers/vfio/vfio_iommu_type1.c >>>>> +++ b/drivers/vfio/vfio_iommu_type1.c >>>>> @@ -299,9 +299,15 @@ static int vfio_lock_acct(struct vfio_dma *dma, = long npage, bool async) >>>>> */ >>>>> static bool is_invalid_reserved_pfn(unsigned long pfn) >>>>> { >>>>> - if (pfn_valid(pfn)) >>>>> - return PageReserved(pfn_to_page(pfn)); >>>>> + struct page *page =3D pfn_to_online_page(pfn); >>>> >>>> Ugh, I just realized this is not a safe conversion until >>>> pfn_to_online_page() is moved over to subsection granularity. As it >>>> stands it will return true for any ZONE_DEVICE pages that share a >>>> section with boot memory. >>> >>> That should not happen right now and I commented back when you introduc= ed subsection support that I don=E2=80=99t want to have ZONE_DEVICE mixed w= ith online pages in a section. Having memory block devices that partially s= pan ZONE_DEVICE would be ... really weird. With something like pfn_active()= - as discussed - we could at least make this check work - but I am not sur= e if we really want to go down that path. In the worst case, some MB of RAM= are lost ... I guess this needs more thought. >>> >> >> I just realized the "boot memory" part. Is that a real thing? IOW, can >> we have ZONE_DEVICE falling into a memory block (with holes)? I somewhat >> have doubts that this would work ... >=20 > One of the real world failure cases that started the subsection effect > is that Persistent Memory collides with System RAM on a 64MB boundary > on shipping platforms. System RAM ends on a 64MB boundary and due to a > lack of memory controller resources PMEM is mapped contiguously at the > end of that boundary. Some more details in the subsection cover letter > / changelogs [1] [2]. It's not sufficient to just lose some memory, > that's the broken implementation that lead to the subsection work > because the lost memory may change from one boot to the next and > software can't reliably inject a padding that conforms to the x86 > 128MB section constraint. Thanks, I thought it was mostly for weird alignment where other parts of=20 the section are basically "holes" and not memory. Yes, it is a real bug that ZONE_DEVICE pages fall into sections that are=20 marked SECTION_IS_ONLINE. >=20 > Suffice to say I think we need your pfn_active() to get subsection > granularity pfn_to_online_page() before PageReserved() can be removed. I agree that we have to fix this. I don't like ZONE_DEVICE pages falling=20 into memory device blocks (e.g., cannot get offlined), but I guess that=20 train is gone :) As long as it's not for memory hotplug, I can most=20 probably live with this. Also, I'd like to get Michals opinion on this and the pfn_active()=20 approach, but I can understand he's busy. This patch set can wait, I won't be working next week besides=20 reading/writing mails either way. Is anybody looking into the pfn_active() thingy? >=20 > [1]: https://lore.kernel.org/linux-mm/156092349300.979959.176037107119577= 35135.stgit@dwillia2-desk3.amr.corp.intel.com/ > [2]: https://lore.kernel.org/linux-mm/156092354368.979959.623244392344095= 2359.stgit@dwillia2-desk3.amr.corp.intel.com/ >=20 --=20 Thanks, David / dhildenb