From: Hari Bathini <hbathini@linux.ibm.com>
To: Michal Suchanek <msuchanek@suse.de>, linuxppc-dev@lists.ozlabs.org
Cc: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/fadump: Remove duplicate message.
Date: Thu, 24 Oct 2019 16:08:08 +0530 [thread overview]
Message-ID: <aa26db2d-48b5-5825-81ab-12ca491a9971@linux.ibm.com> (raw)
In-Reply-To: <20191023175651.24833-1-msuchanek@suse.de>
Michal, thanks for looking into this.
On 23/10/19 11:26 PM, Michal Suchanek wrote:
> There is duplicate message about lack of support by firmware in
> fadump_reserve_mem and setup_fadump. Due to different capitalization it
> is clear that the one in setup_fadump is shown on boot. Remove the
> duplicate that is not shown.
Actually, the message in fadump_reserve_mem() is logged. fadump_reserve_mem()
executes first and sets fw_dump.fadump_enabled to `0`, if fadump is not supported.
So, the other message in setup_fadump() doesn't get logged anymore with recent
changes. The right thing to do would be to remove similar message in setup_fadump() instead.
- Hari
next prev parent reply other threads:[~2019-10-24 10:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 7:54 [PATCH v2 rebased] powerpc/fadump: when fadump is supported register the fadump sysfs files Michal Suchanek
2019-10-23 17:56 ` [PATCH] powerpc/fadump: Remove duplicate message Michal Suchanek
2019-10-24 10:38 ` Hari Bathini [this message]
2019-10-24 11:16 ` Michal Suchánek
2019-11-07 16:42 ` Michal Suchánek
2019-11-07 16:47 ` [PATCH v3] powerpc/fadump: when fadump is supported register the fadump sysfs files Michal Suchanek
2019-11-08 11:38 ` Hari Bathini
2019-11-14 9:08 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa26db2d-48b5-5825-81ab-12ca491a9971@linux.ibm.com \
--to=hbathini@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=msuchanek@suse.de \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).