From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Randy Dunlap <rdunlap@infradead.org>, kernel test robot <lkp@intel.com>
Cc: PowerPC <linuxppc-dev@lists.ozlabs.org>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: mmu.c:undefined reference to `patch__hash_page_A0'
Date: Sun, 18 Apr 2021 12:43:54 +0200 [thread overview]
Message-ID: <ab9d4f9e-add6-900b-9fa7-83d5f7d1108b@csgroup.eu> (raw)
In-Reply-To: <06227600-c5c5-3da7-a495-ae0b0849b62d@infradead.org>
Le 18/04/2021 à 02:02, Randy Dunlap a écrit :
> HI--
>
> I no longer see this build error.
Fixed by https://github.com/torvalds/linux/commit/acdad8fb4a1574323db88f98a38b630691574e16
> However:
>
> On 2/27/21 2:24 AM, kernel test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: 3fb6d0e00efc958d01c2f109c8453033a2d96796
>> commit: 259149cf7c3c6195e6199e045ca988c31d081cab powerpc/32s: Only build hash code when CONFIG_PPC_BOOK3S_604 is selected
>> date: 4 weeks ago
>> config: powerpc64-randconfig-r013-20210227 (attached as .config)
>
> ktr/lkp, this is a PPC32 .config file that is attached, not PPC64.
>
> Also:
>
>> compiler: powerpc-linux-gcc (GCC) 9.3.0
...
>
> I do see this build error:
>
> powerpc-linux-ld: arch/powerpc/boot/wrapper.a(decompress.o): in function `partial_decompress':
> decompress.c:(.text+0x1f0): undefined reference to `__decompress'
>
> when either
> CONFIG_KERNEL_LZO=y
> or
> CONFIG_KERNEL_LZMA=y
>
> but the build succeeds when either
> CONFIG_KERNEL_GZIP=y
> or
> CONFIG_KERNEL_XZ=y
>
> I guess that is due to arch/powerpc/boot/decompress.c doing this:
>
> #ifdef CONFIG_KERNEL_GZIP
> # include "decompress_inflate.c"
> #endif
>
> #ifdef CONFIG_KERNEL_XZ
> # include "xz_config.h"
> # include "../../../lib/decompress_unxz.c"
> #endif
>
>
> It would be nice to require one of KERNEL_GZIP or KERNEL_XZ
> to be set/enabled (maybe unless a uImage is being built?).
Can you test by
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/a74fce4dfc9fa32da6ce3470bbedcecf795de1ec.1591189069.git.christophe.leroy@csgroup.eu/
?
Thanks
Christophe
next prev parent reply other threads:[~2021-04-18 10:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202102271820.WlZCxtzY-lkp@intel.com>
2021-04-18 0:02 ` mmu.c:undefined reference to `patch__hash_page_A0' Randy Dunlap
2021-04-18 10:43 ` Christophe Leroy [this message]
2021-04-18 17:15 ` Randy Dunlap
2021-04-18 18:35 ` Christophe Leroy
2021-04-21 8:43 ` Christophe Leroy
2021-04-22 2:16 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab9d4f9e-add6-900b-9fa7-83d5f7d1108b@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).