* [PATCH] powerpc/mm: move a KERN_WARNING message to KERN_DEBUG
@ 2019-02-05 18:03 Laurent Vivier
2019-02-05 18:11 ` Christophe Leroy
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Vivier @ 2019-02-05 18:03 UTC (permalink / raw)
To: linux-kernel; +Cc: linuxppc-dev, David Gibson
resize_hpt_for_hotplug() reports a warning when it cannot
increase the hash page table ("Unable to resize hash page
table to target order") but this is not blocking and
can make user thinks something has not worked properly.
If the operation cannot be done the real error message
will be reported by arch_add_memory() if create_section_mapping()
fails.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
arch/powerpc/mm/hash_utils_64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
index 0cc7fbc3bd1c..b762bdceb510 100644
--- a/arch/powerpc/mm/hash_utils_64.c
+++ b/arch/powerpc/mm/hash_utils_64.c
@@ -778,7 +778,7 @@ void resize_hpt_for_hotplug(unsigned long new_mem_size)
rc = mmu_hash_ops.resize_hpt(target_hpt_shift);
if (rc && (rc != -ENODEV))
- printk(KERN_WARNING
+ printk(KERN_DEBUG
"Unable to resize hash page table to target order %d: %d\n",
target_hpt_shift, rc);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/mm: move a KERN_WARNING message to KERN_DEBUG
2019-02-05 18:03 [PATCH] powerpc/mm: move a KERN_WARNING message to KERN_DEBUG Laurent Vivier
@ 2019-02-05 18:11 ` Christophe Leroy
0 siblings, 0 replies; 2+ messages in thread
From: Christophe Leroy @ 2019-02-05 18:11 UTC (permalink / raw)
To: Laurent Vivier, linux-kernel; +Cc: linuxppc-dev, David Gibson
Le 05/02/2019 à 19:03, Laurent Vivier a écrit :
> resize_hpt_for_hotplug() reports a warning when it cannot
> increase the hash page table ("Unable to resize hash page
> table to target order") but this is not blocking and
> can make user thinks something has not worked properly.
>
> If the operation cannot be done the real error message
> will be reported by arch_add_memory() if create_section_mapping()
> fails.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> arch/powerpc/mm/hash_utils_64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
> index 0cc7fbc3bd1c..b762bdceb510 100644
> --- a/arch/powerpc/mm/hash_utils_64.c
> +++ b/arch/powerpc/mm/hash_utils_64.c
> @@ -778,7 +778,7 @@ void resize_hpt_for_hotplug(unsigned long new_mem_size)
>
> rc = mmu_hash_ops.resize_hpt(target_hpt_shift);
> if (rc && (rc != -ENODEV))
> - printk(KERN_WARNING
> + printk(KERN_DEBUG
You should use pr_debug() instead.
Christophe
> "Unable to resize hash page table to target order %d: %d\n",
> target_hpt_shift, rc);
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-05 18:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-05 18:03 [PATCH] powerpc/mm: move a KERN_WARNING message to KERN_DEBUG Laurent Vivier
2019-02-05 18:11 ` Christophe Leroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).