From: Tim Abbott <tabbott@MIT.EDU>
To: Paul Mackerras <paulus@samba.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: Please revert edada399 and 9203fc9c
Date: Tue, 28 Apr 2009 11:47:15 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.1.10.0904281126550.15450@vinegar-pot.mit.edu> (raw)
In-Reply-To: <18934.35969.872225.70725@cargo.ozlabs.ibm.com>
> Please revert commits edada399 ("powerpc: Use TEXT_TEXT macro in
> linker script.") and 9203fc9c ("powerpc: Use __REF macro instead of
> old .text.init.refok."), which depends on edada399.
Paul,
Sorry for breaking the build. I will be sure to CC you and
linuxppc-dev@ozlabs.org on future powerpc patches in this section name
cleanup project.
I think just reverting commits edada399 and 9203fc9c will cause a section
mismatch warning since commit 27b18332 removed the support code for the
.text.init.refok section. The following patch I believe should fix this
by effectively reverting just commit edada399. Can someone who has a
64-bit powerpc machine confirm?
-Tim Abbott
--
powerpc: Revert switch to TEXT_TEXT in linker script
Commit edada399 broke the build on 64-bit powerpc because it moved the
__ftr_alt_* sections of a file away from the .text section, causing
link failures due to relative conditional branch targets being too far
away from the branch instructions. This happens on pretty much all
64-bit powerpc configs.
This change reverts commit edada399 while preserving the update from
the *.refok sections to .ref.text that has happened since.
Signed-off-by: Tim Abbott <tabbott@mit.edu>
---
arch/powerpc/kernel/vmlinux.lds.S | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/vmlinux.lds.S b/arch/powerpc/kernel/vmlinux.lds.S
index 433ae11..a047a6c 100644
--- a/arch/powerpc/kernel/vmlinux.lds.S
+++ b/arch/powerpc/kernel/vmlinux.lds.S
@@ -54,8 +54,8 @@ SECTIONS
ALIGN_FUNCTION();
HEAD_TEXT
_text = .;
- TEXT_TEXT
- *(.fixup __ftr_alt_*)
+ /* careful! __ftr_alt_* sections need to be close to .text */
+ *(.text .fixup __ftr_alt_* .ref.text)
SCHED_TEXT
LOCK_TEXT
KPROBES_TEXT
--
1.6.2.1
next prev parent reply other threads:[~2009-04-28 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 4:56 Please revert edada399 and 9203fc9c Paul Mackerras
2009-04-28 8:35 ` Sam Ravnborg
2009-04-28 20:52 ` Benjamin Herrenschmidt
2009-04-28 15:47 ` Tim Abbott [this message]
2009-04-29 0:22 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.0904281126550.15450@vinegar-pot.mit.edu \
--to=tabbott@mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).