From: Thomas Gleixner <tglx@linutronix.de>
To: Don Zickus <dzickus@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
ppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [RFC GIT Pull] core watchdog sanitizing
Date: Mon, 2 Oct 2017 22:45:05 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1710022243480.2114@nanos> (raw)
In-Reply-To: <20171002203209.rjug625pfmgh674j@redhat.com>
On Mon, 2 Oct 2017, Don Zickus wrote:
> On Mon, Oct 02, 2017 at 07:32:57PM +0000, Thomas Gleixner wrote:
> > static void softlockup_reconfigure_threads(void)
>
> There is a second copy of ^^^^, you will need to add identical locking there
> too.
Good catch, but then we might move it further out
> > + cpus_read_unlock();
> > + /*
> > + * Must be called outside the cpus locked section to prevent
> > + * recursive locking in the perf code.
> > + */
> > + __lockup_detector_cleanup();
Or not due to this ....
Thanks,
tglx
prev parent reply other threads:[~2017-10-02 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.20.1710011217510.3874@nanos>
[not found] ` <CA+55aFxQsmSb=zohGZOZK7eR4n5xOHNArmCa9j1b7+wJ+khQrg@mail.gmail.com>
2017-10-02 18:46 ` [RFC GIT Pull] core watchdog sanitizing Thomas Gleixner
2017-10-02 19:04 ` Linus Torvalds
2017-10-02 19:32 ` Thomas Gleixner
2017-10-02 20:32 ` Don Zickus
2017-10-02 20:45 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1710022243480.2114@nanos \
--to=tglx@linutronix.de \
--cc=benh@kernel.crashing.org \
--cc=dzickus@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).