From: Julia Lawall <julia.lawall@inria.fr>
To: Jeremy Kerr <jk@ozlabs.org>
Cc: Nic Volanschi <eugene.volanschi@inria.fr>,
Arnd Bergmann <arnd@arndb.de>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/spufs: adjust list element pointer type
Date: Fri, 8 May 2020 12:40:08 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2005081237210.5307@hadrien> (raw)
In-Reply-To: <4c9cc9184213ded65489cb95050046c8904ddad8.camel@ozlabs.org>
On Fri, 8 May 2020, Jeremy Kerr wrote:
> Hi Julia,
>
> > Other uses of &gang->aff_list_head, eg in spufs_assert_affinity, indicate
> > that the list elements have type spu_context, not spu as used here. Change
> > the type of tmp accordingly.
>
> Looks good to me; we could even use ctx there, rather than the separate
> tmp variable.
I thought about that, but it seemed a little bit abusive, since ctx is
used in an iteration over another list. But if you prefer that I can
change it.
julia
>
> Reviewed-by: Jeremy Kerr <jk@ozlabs.org>
>
> Cheers,
>
>
> Jeremy
>
>
next prev parent reply other threads:[~2020-05-08 10:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 9:12 [PATCH] powerpc/spufs: adjust list element pointer type Julia Lawall
2020-05-08 10:13 ` Jeremy Kerr
2020-05-08 10:40 ` Julia Lawall [this message]
2022-02-15 5:26 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2005081237210.5307@hadrien \
--to=julia.lawall@inria.fr \
--cc=arnd@arndb.de \
--cc=eugene.volanschi@inria.fr \
--cc=jk@ozlabs.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).