Re: [PATCH 1/2] pmac-zilog: add platform driver

[fthain@telegraphics.com.au]

On Fri, 8 Jan 2010, Geert Uytterhoeven wrote:

> On Sat, Jan 2, 2010 at 17:39, Finn Thain <fthain@telegraphics.com.au> 
> wrote:
> > On Sat, 2 Jan 2010, Geert Uytterhoeven wrote:
> >> On Tue, Nov 17, 2009 at 10:04, Finn Thain 
> >> <fthain@telegraphics.com.au> wrote: BTW, there are a few other minor 
> >> checkpatch issues with some of the other patches in the series, too.
> >
> > I ran checkpatch on all those patches before I submitted them. I 
> > ignored some of the complaints about whitespace where I felt that 
> > checkpatch got it wrong (space character following tab character, 
> > IIRC).
> >
> > checkpatch found lots of mistakes that I did fix, but it can't 
> > determine the most human readable style in all cases, especially where 
> > consistency with the surrounding code is actually more conducive to 
> > readability than strict but sporadic conformance to simple rules would 
> > be.
> 
> It seems your editor adds spaces to lines that are continuations of the 
> previous statement.

I put in spaces after tabs for hard wrapped lines so that code always 
renders properly regardless of the tab settings that might to be applied 
by any editor, browser, word processor, mailer, tty discipline, publisher, 
etc. that might stand between the human reader and the code.

Documentation/CodingStyle says that those indented lines should be 
"substantially to the right", but checkpatch doesn't conform and nor does 
most kernel code. Some code does follow my preference, which is more 
readable, and also happens to follow the example of the lisp code found in 
the same style guide.

But if you prefer no spaces after tabs, I can do that instead. I'm not 
fussed.

> I fixes them up and applied all your patches to linux-m68k.git.

Thanks. I'll resend the patch to address your comments earlier in the 
thread.

Finn

> The other warnings were indeed false positives or complains about
> keeping consistency
> with the surrounding code.
> 
> Gr{oetje,eeting}s,
> 
> 						Geert