From: Russell Currey <ruscur@russell.cc>
To: Qian Cai <cai@lca.pw>, mpe@ellerman.id.au
Cc: sbobroff@linux.ibm.com, linux-kernel@vger.kernel.org,
oohall@gmail.com, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/eeh_cache: fix a W=1 kernel-doc warning
Date: Fri, 28 Jun 2019 13:02:11 +1000 [thread overview]
Message-ID: <b21dc7e6aa44f984fe64a2bd6c9a3158c6a10bf8.camel@russell.cc> (raw)
In-Reply-To: <1559767579-7151-1-git-send-email-cai@lca.pw>
On Wed, 2019-06-05 at 16:46 -0400, Qian Cai wrote:
> The opening comment mark "/**" is reserved for kernel-doc comments,
> so
> it will generate a warning with "make W=1".
>
> arch/powerpc/kernel/eeh_cache.c:37: warning: cannot understand
> function
> prototype: 'struct pci_io_addr_range
>
> Since this is not a kernel-doc for the struct below, but rather an
> overview of this source eeh_cache.c, just use the free-form comments
> kernel-doc syntax instead.
>
> Signed-off-by: Qian Cai <cai@lca.pw>
Looks good to me.
Acked-by: Russell Currey <ruscur@russell.cc>
next prev parent reply other threads:[~2019-06-28 4:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 20:46 [PATCH] powerpc/eeh_cache: fix a W=1 kernel-doc warning Qian Cai
2019-06-27 19:55 ` Qian Cai
2019-06-28 3:02 ` Russell Currey [this message]
2019-07-03 14:27 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b21dc7e6aa44f984fe64a2bd6c9a3158c6a10bf8.camel@russell.cc \
--to=ruscur@russell.cc \
--cc=cai@lca.pw \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
--cc=sbobroff@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).