From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xR1FQ3pvqzDqjB for ; Tue, 8 Aug 2017 01:11:06 +1000 (AEST) Subject: Re: [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init() To: SF Markus Elfring , linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras Cc: LKML , kernel-janitors@vger.kernel.org References: From: Geoff Levand Message-ID: Date: Mon, 7 Aug 2017 08:10:59 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 08/07/2017 03:52 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 7 Aug 2017 12:37:01 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. NACK When a user asks me for help I would certainly like to get 'Could not allocate cache tags' as apposed to nothing, since the return value of ps3vram_cache_init() is not checked. If you want to make an improvement please add a check for success of ps3vram_cache_init() in ps3vram_probe(). -Geoff