From: Andrew Donnellan <ajd@linux.ibm.com>
To: Russell Currey <ruscur@russell.cc>, linuxppc-dev@lists.ozlabs.org
Cc: nayna@linux.ibm.com, gjoyce@linux.ibm.com, bgray@linux.ibm.com,
brking@linux.ibm.com, gcwilson@linux.ibm.com,
stefanb@linux.ibm.com
Subject: Re: [PATCH 4/4] powerpc/pseries: Implement signed update for PLPKS objects
Date: Wed, 04 Jan 2023 18:39:44 +1100 [thread overview]
Message-ID: <b7d73cde013ce70f69b716b1dbf35a5a78ccffde.camel@linux.ibm.com> (raw)
In-Reply-To: <6a9a6c4fb24a417447951a23ca4c96c914ff246b.camel@russell.cc>
On Wed, 2023-01-04 at 15:04 +1100, Russell Currey wrote:
> > + if (!rc) {
> > + rc = plpks_confirm_object_flushed(label, auth);
> > + rc = pseries_status_to_err(rc);
>
> Doesn't plpks_confirm_object_flushed() already return a Linux-
> friendly
> error code? If I'm reading this right, we'd be replacing any non-
> zero
> return code with -EINVAL.
Good catch, will fix.
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2023-01-04 7:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 7:16 [PATCH 0/4] PLPKS bugfixes and enhancements Andrew Donnellan
2022-12-20 7:16 ` [PATCH 1/4] powerpc/pseries: Fix handling of PLPKS object flushing timeout Andrew Donnellan
2023-01-04 3:45 ` Russell Currey
2022-12-20 7:16 ` [PATCH 2/4] powerpc/pseries: Fix alignment of PLPKS structures and buffers Andrew Donnellan
2023-01-04 3:46 ` Russell Currey
2022-12-20 7:16 ` [PATCH 3/4] powerpc/pseries: Expose PLPKS config values, support additional fields Andrew Donnellan
2023-01-04 3:57 ` Russell Currey
2023-01-04 7:42 ` Andrew Donnellan
2022-12-20 7:16 ` [PATCH 4/4] powerpc/pseries: Implement signed update for PLPKS objects Andrew Donnellan
2023-01-04 4:04 ` Russell Currey
2023-01-04 7:39 ` Andrew Donnellan [this message]
2023-01-06 10:54 ` Michael Ellerman
2023-01-09 5:04 ` Andrew Donnellan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7d73cde013ce70f69b716b1dbf35a5a78ccffde.camel@linux.ibm.com \
--to=ajd@linux.ibm.com \
--cc=bgray@linux.ibm.com \
--cc=brking@linux.ibm.com \
--cc=gcwilson@linux.ibm.com \
--cc=gjoyce@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nayna@linux.ibm.com \
--cc=ruscur@russell.cc \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).