From: Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com>
To: Santosh Sivaraj <santosh@fossix.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Mahesh Salgaonkar <mahesh@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Chandan Rajendra <chandan@linux.vnet.ibm.com>,
Reza Arbab <arbab@linux.ibm.com>
Subject: Re: [PATCH v8 1/7] powerpc/mce: Schedule work from irq_work
Date: Sat, 10 Aug 2019 00:25:48 +0530 [thread overview]
Message-ID: <bbfb2cf0-50ae-3170-976b-adb6cd2d9f82@linux.vnet.ibm.com> (raw)
In-Reply-To: <20190807145700.25599-2-santosh@fossix.org>
On 8/7/19 8:26 PM, Santosh Sivaraj wrote:
> schedule_work() cannot be called from MCE exception context as MCE can
> interrupt even in interrupt disabled context.
>
> fixes: 733e4a4c ("powerpc/mce: hookup memory_failure for UE errors")
> Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
> ---
> arch/powerpc/kernel/mce.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/kernel/mce.c b/arch/powerpc/kernel/mce.c
> index b18df633eae9..0ab6fa7cbbbb 100644
> --- a/arch/powerpc/kernel/mce.c
> +++ b/arch/powerpc/kernel/mce.c
> @@ -144,7 +144,6 @@ void save_mce_event(struct pt_regs *regs, long handled,
> if (phys_addr != ULONG_MAX) {
> mce->u.ue_error.physical_address_provided = true;
> mce->u.ue_error.physical_address = phys_addr;
> - machine_check_ue_event(mce);
> }
> }
> return;
> @@ -275,8 +274,7 @@ static void machine_process_ue_event(struct work_struct *work)
> }
> }
> /*
> - * process pending MCE event from the mce event queue. This function will be
> - * called during syscall exit.
> + * process pending MCE event from the mce event queue.
> */
> static void machine_check_process_queued_event(struct irq_work *work)
> {
> @@ -292,6 +290,10 @@ static void machine_check_process_queued_event(struct irq_work *work)
> while (__this_cpu_read(mce_queue_count) > 0) {
> index = __this_cpu_read(mce_queue_count) - 1;
> evt = this_cpu_ptr(&mce_event_queue[index]);
> +
> + if (evt->error_type == MCE_ERROR_TYPE_UE)
> + machine_check_ue_event(evt);
This will work only for the event that are queued by mce handler, others
will get ignored. I think you should introduce a separate irq work queue
for schedule_work().
Thanks,
-Mahesh.
next prev parent reply other threads:[~2019-08-09 18:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 14:56 [PATCH v8 0/7] powerpc: implement machine check safe memcpy Santosh Sivaraj
2019-08-07 14:56 ` [PATCH v8 1/7] powerpc/mce: Schedule work from irq_work Santosh Sivaraj
2019-08-09 18:55 ` Mahesh Jagannath Salgaonkar [this message]
2019-08-07 14:56 ` [PATCH v8 2/7] powerpc/mce: Make machine_check_ue_event() static Santosh Sivaraj
2019-08-07 14:56 ` [PATCH v8 3/7] powerpc/mce: Fix MCE handling for huge pages Santosh Sivaraj
2019-08-09 19:06 ` Mahesh Jagannath Salgaonkar
2019-08-11 1:32 ` Santosh Sivaraj
2019-08-07 14:56 ` [PATCH v8 4/7] extable: Add function to search only kernel exception table Santosh Sivaraj
2019-08-07 14:56 ` [PATCH v8 5/7] powerpc/memcpy: Add memcpy_mcsafe for pmem Santosh Sivaraj
2019-08-07 14:56 ` [PATCH v8 6/7] powerpc/mce: Handle UE event for memcpy_mcsafe Santosh Sivaraj
2019-08-07 14:57 ` [PATCH v8 7/7] powerpc: add machine check safe copy_to_user Santosh Sivaraj
2019-08-10 9:33 ` Michael Ellerman
2019-08-11 1:35 ` Santosh Sivaraj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbfb2cf0-50ae-3170-976b-adb6cd2d9f82@linux.vnet.ibm.com \
--to=mahesh@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=arbab@linux.ibm.com \
--cc=chandan@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=santosh@fossix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).