From: Pratik Sampat <psampat@linux.ibm.com>
To: Nicholas Piggin <npiggin@gmail.com>,
benh@kernel.crashing.org, ego@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
mikey@neuling.org, mpe@ellerman.id.au, paulus@samba.org,
pratik.r.sampat@gmail.com, ravi.bangoria@linux.ibm.com,
svaidy@linux.ibm.com
Subject: Re: [PATCH v2 0/3] Power10 basic energy management
Date: Mon, 13 Jul 2020 15:32:12 +0530 [thread overview]
Message-ID: <bc6494c0-9a17-2416-c6cc-15612020f497@linux.ibm.com> (raw)
In-Reply-To: <1594617564.57k8bsyfd0.astroid@bobo.none>
Thank you for your comments,
On 13/07/20 10:53 am, Nicholas Piggin wrote:
> Excerpts from Pratik Rajesh Sampat's message of July 10, 2020 3:22 pm:
>> Changelog v1 --> v2:
>> 1. Save-restore DAWR and DAWRX unconditionally as they are lost in
>> shallow idle states too
>> 2. Rename pnv_first_spr_loss_level to pnv_first_fullstate_loss_level to
>> correct naming terminology
>>
>> Pratik Rajesh Sampat (3):
>> powerpc/powernv/idle: Exclude mfspr on HID1,4,5 on P9 and above
>> powerpc/powernv/idle: save-restore DAWR0,DAWRX0 for P10
>> powerpc/powernv/idle: Rename pnv_first_spr_loss_level variable
>>
>> arch/powerpc/platforms/powernv/idle.c | 34 +++++++++++++++++----------
>> 1 file changed, 22 insertions(+), 12 deletions(-)
> These look okay to me, but the CPU_FTR_ARCH_300 test for
> pnv_power9_idle_init() is actually wrong, it should be a PVR test
> because idle is not completely architected (not even shallow stop
> states, unfortunately).
>
> It doesn't look like we support POWER10 idle correctly yet, and on older
> kernels it wouldn't work even if we fixed newer, so ideally the PVR
> check would be backported as a fix in the front of the series.
>
> Sadly, we have no OPAL idle driver yet. Hopefully we will before the
> next processor shows up :P
>
> Thanks,
> Nick
So if I understand this correctly, in powernv/idle.c where we check for
CPU_FTR_ARCH_300, we should rather be making a pvr_version_is(PVR_POWER9)
check instead?
Of course, the P10 PVR and its relevant checks will have to be added then too.
Thanks
Pratik
next prev parent reply other threads:[~2020-07-13 10:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 5:22 [PATCH v2 0/3] Power10 basic energy management Pratik Rajesh Sampat
2020-07-10 5:22 ` [PATCH v2 1/3] powerpc/powernv/idle: Exclude mfspr on HID1, 4, 5 on P9 and above Pratik Rajesh Sampat
2020-07-13 5:53 ` Nicholas Piggin
2020-07-10 5:22 ` [PATCH v2 2/3] powerpc/powernv/idle: save-restore DAWR0, DAWRX0 for P10 Pratik Rajesh Sampat
2020-07-13 5:52 ` Nicholas Piggin
2020-07-20 4:30 ` Ravi Bangoria
2020-07-20 4:24 ` [PATCH v2 2/3] powerpc/powernv/idle: save-restore DAWR0,DAWRX0 " Ravi Bangoria
2020-07-24 1:25 ` Michael Neuling
2020-07-24 6:34 ` Pratik Sampat
2020-07-10 5:22 ` [PATCH v2 3/3] powerpc/powernv/idle: Rename pnv_first_spr_loss_level variable Pratik Rajesh Sampat
2020-07-13 5:23 ` [PATCH v2 0/3] Power10 basic energy management Nicholas Piggin
2020-07-13 10:02 ` Pratik Sampat [this message]
2020-07-13 16:50 ` Nicholas Piggin
2020-07-13 18:27 ` Pratik Sampat
2020-07-13 10:48 ` Gautham R Shenoy
2020-07-13 16:58 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc6494c0-9a17-2416-c6cc-15612020f497@linux.ibm.com \
--to=psampat@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=pratik.r.sampat@gmail.com \
--cc=ravi.bangoria@linux.ibm.com \
--cc=svaidy@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).