Re: [PATCH] cxl: Configure PSL to not use APC virtual machines

From: christophe lombard <clombard@linux.vnet.ibm.com>
To: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>,
	linuxppc-dev@lists.ozlabs.org,
	Frederic Barrat <fbarrat@linux.vnet.ibm.com>
Cc: Philippe Bergheaud <philippe.bergheaud@fr.ibm.com>,
	"Alastair D'Silva" <alastair@linux.ibm.com>,
	Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
	Christophe Lombard <christophe_lombard@fr.ibm.com>
Subject: Re: [PATCH] cxl: Configure PSL to not use APC virtual machines
Date: Mon, 7 May 2018 17:57:58 +0200	[thread overview]
Message-ID: <c0c8e359-91d5-ae93-f427-427c15337e88@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180417051102.7577-1-vaibhav@linux.vnet.ibm.com>

Le 17/04/2018 à 07:11, Vaibhav Jain a écrit :
> APC virtual machines arent used on POWER-9 chips and are already
> disabled in on-chip CAPP. They also need to be disabled on the PSL via
> 'PSL Data Send Control Register' by setting bit(47). This forces the
> PSL to send commands to CAPP with queue.id == 0.
> 
> Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
> ---
>   drivers/misc/cxl/pci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> index c32432168e6b..af30ee848d35 100644
> --- a/drivers/misc/cxl/pci.c
> +++ b/drivers/misc/cxl/pci.c
> @@ -516,9 +516,9 @@ static int init_implementation_adapter_regs_psl9(struct cxl *adapter,
>   	cxl_p1_write(adapter, CXL_PSL9_FIR_CNTL, psl_fircntl);
> 
>   	/* Setup the PSL to transmit packets on the PCIe before the
> -	 * CAPP is enabled
> +	 * CAPP is enabled. Make sure that CAPP virtual machines are disabled
>   	 */
> -	cxl_p1_write(adapter, CXL_PSL9_DSNDCTL, 0x0001001000002A10ULL);
> +	cxl_p1_write(adapter, CXL_PSL9_DSNDCTL, 0x0001001000012A10ULL);
> 
>   	/*
>   	 * A response to an ASB_Notify request is returned by the
> 

Thanks

Reviewed-by: Christophe Lombard <clombard@linux.vnet.ibm.com>