From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C03DBC282CB for ; Tue, 5 Feb 2019 13:07:19 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED4CC20844 for ; Tue, 5 Feb 2019 13:07:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED4CC20844 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 43v4c46nlyzDqNC for ; Wed, 6 Feb 2019 00:07:16 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=kaod.org (client-ip=46.105.76.150; helo=10.mo178.mail-out.ovh.net; envelope-from=clg@kaod.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=kaod.org Received: from 10.mo178.mail-out.ovh.net (10.mo178.mail-out.ovh.net [46.105.76.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43v4Wd4CGgzDqM9 for ; Wed, 6 Feb 2019 00:03:24 +1100 (AEDT) Received: from player756.ha.ovh.net (unknown [10.109.146.211]) by mo178.mail-out.ovh.net (Postfix) with ESMTP id 9550F4E84A for ; Tue, 5 Feb 2019 14:03:20 +0100 (CET) Received: from kaod.org (deibp9eh1--blueice1n0.emea.ibm.com [195.212.29.162]) (Authenticated sender: clg@kaod.org) by player756.ha.ovh.net (Postfix) with ESMTPSA id A3B5E2684DE3; Tue, 5 Feb 2019 13:03:13 +0000 (UTC) Subject: Re: [PATCH 15/19] KVM: PPC: Book3S HV: add get/set accessors for the source configuration To: David Gibson References: <20190107184331.8429-1-clg@kaod.org> <20190107184331.8429-16-clg@kaod.org> <20190204052148.GH1927@umbus.fritz.box> <02ee0470-3c6a-5c5c-a903-44e172ce1ed5@kaod.org> <20190205053233.GG22661@umbus.fritz.box> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: Date: Tue, 5 Feb 2019 14:03:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190205053233.GG22661@umbus.fritz.box> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 9914674582449392519 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtledrkeeigdeggecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2/5/19 6:32 AM, David Gibson wrote: > On Mon, Feb 04, 2019 at 05:07:28PM +0100, Cédric Le Goater wrote: >> On 2/4/19 6:21 AM, David Gibson wrote: >>> On Mon, Jan 07, 2019 at 07:43:27PM +0100, Cédric Le Goater wrote: >>>> Theses are use to capure the XIVE EAS table of the KVM device, the >>>> configuration of the source targets. >>>> >>>> Signed-off-by: Cédric Le Goater >>>> --- >>>> arch/powerpc/include/uapi/asm/kvm.h | 11 ++++ >>>> arch/powerpc/kvm/book3s_xive_native.c | 87 +++++++++++++++++++++++++++ >>>> 2 files changed, 98 insertions(+) >>>> >>>> diff --git a/arch/powerpc/include/uapi/asm/kvm.h b/arch/powerpc/include/uapi/asm/kvm.h >>>> index 1a8740629acf..faf024f39858 100644 >>>> --- a/arch/powerpc/include/uapi/asm/kvm.h >>>> +++ b/arch/powerpc/include/uapi/asm/kvm.h >>>> @@ -683,9 +683,20 @@ struct kvm_ppc_cpu_char { >>>> #define KVM_DEV_XIVE_SAVE_EQ_PAGES 4 >>>> #define KVM_DEV_XIVE_GRP_SOURCES 2 /* 64-bit source attributes */ >>>> #define KVM_DEV_XIVE_GRP_SYNC 3 /* 64-bit source attributes */ >>>> +#define KVM_DEV_XIVE_GRP_EAS 4 /* 64-bit eas attributes */ >>>> >>>> /* Layout of 64-bit XIVE source attribute values */ >>>> #define KVM_XIVE_LEVEL_SENSITIVE (1ULL << 0) >>>> #define KVM_XIVE_LEVEL_ASSERTED (1ULL << 1) >>>> >>>> +/* Layout of 64-bit eas attribute values */ >>>> +#define KVM_XIVE_EAS_PRIORITY_SHIFT 0 >>>> +#define KVM_XIVE_EAS_PRIORITY_MASK 0x7 >>>> +#define KVM_XIVE_EAS_SERVER_SHIFT 3 >>>> +#define KVM_XIVE_EAS_SERVER_MASK 0xfffffff8ULL >>>> +#define KVM_XIVE_EAS_MASK_SHIFT 32 >>>> +#define KVM_XIVE_EAS_MASK_MASK 0x100000000ULL >>>> +#define KVM_XIVE_EAS_EISN_SHIFT 33 >>>> +#define KVM_XIVE_EAS_EISN_MASK 0xfffffffe00000000ULL >>>> + >>>> #endif /* __LINUX_KVM_POWERPC_H */ >>>> diff --git a/arch/powerpc/kvm/book3s_xive_native.c b/arch/powerpc/kvm/book3s_xive_native.c >>>> index f2de1bcf3b35..0468b605baa7 100644 >>>> --- a/arch/powerpc/kvm/book3s_xive_native.c >>>> +++ b/arch/powerpc/kvm/book3s_xive_native.c >>>> @@ -525,6 +525,88 @@ static int kvmppc_xive_native_sync(struct kvmppc_xive *xive, long irq, u64 addr) >>>> return 0; >>>> } >>>> >>>> +static int kvmppc_xive_native_set_eas(struct kvmppc_xive *xive, long irq, >>>> + u64 addr) >>> >>> I'd prefer to avoid the name "EAS" here. IIUC these aren't "raw" EAS >>> values, but rather essentially the "source config" in the terminology >>> of the PAPR hcalls. Which, yes, is basically implemented by setting >>> the EAS, but since it's the PAPR architected state that we need to >>> preserve across migration, I'd prefer to stick as close as we can to >>> the PAPR terminology. >> >> But we don't have an equivalent name in the PAPR specs for the tuple >> (prio, server). We could use the generic 'target' name may be ? even >> if this is usually referring to a CPU number. > > Um.. what? That's about terminology for one of the fields in this > thing, not about the name for the thing itself. > >> Or, IVE (Interrupt Vector Entry) ? which makes some sense. >> This is was the former name in HW. I think we recycle it for KVM. > > That's a terrible idea, which will make a confusing situation even > more confusing. Let's use SOURCE_CONFIG and QUEUE_CONFIG. The KVM ioctls are very similar to the hcalls anyhow. C.