From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84DDAC43387 for ; Sat, 29 Dec 2018 18:57:05 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF78D20873 for ; Sat, 29 Dec 2018 18:57:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p/4twUS6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF78D20873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 43Rt9B1hP1zDqFv for ; Sun, 30 Dec 2018 05:57:02 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="p/4twUS6"; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::542; helo=mail-pg1-x542.google.com; envelope-from=schmitzmic@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="p/4twUS6"; dkim-atps=neutral Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43Rt6Q4HsHzDqDt for ; Sun, 30 Dec 2018 05:54:37 +1100 (AEDT) Received: by mail-pg1-x542.google.com with SMTP id w6so11301610pgl.6 for ; Sat, 29 Dec 2018 10:54:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=GbTXTG3fTjjT0j2bl1UC5cYq6voZf08wx/Uq2Iez900=; b=p/4twUS6baZ4btZZMrTxl4N2PJrH0sNPYZMwbbNcylXpXzmnSSzNkyXtyHx5fIu8nl Pf2LCZ+ecFESmMGSXROG/sN4aXo01Y3VyUw4yCP9idN9xkC59nsxuJ4WtTVPOH4653MB R6G10obPANMw9NR23O9ncRzZoMEaSlthOgYChdVkSNeN0k8nvPrtQVZnopOV20MYqivO G/X+jhRq6ZiH1g70WAryxIKkxYninGJ1XkXFoCMm1HgBqvHRajQo1G3h4bpq9DFKEsVQ eXq556GAYeAQ3Pejtkh2SzRLb2vUb0L0TTxbIabfq9NiCanDZMbyCRFiAMLyAOupZQlT YjuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=GbTXTG3fTjjT0j2bl1UC5cYq6voZf08wx/Uq2Iez900=; b=hiXIxlkHwsJUt6GV9xEo2zeMmsU7RPAj774C12Vz+nDMzBwCs2Ne2xvgjWjykOa/DN uNHQhmYafF31URbTwitEDWwdBP8n2DtmtxxzlwvVrZhHILW+qLxvA7jPuU/Hjp1kGadp XUxUyRntzjfDjEwfwQRGJZCE6ajvfOyhz5cr8HR3Uhw/wk36DlArzL1aoxQ5IV0UcibR ANgqcRIGnRaFrKdijDYfcW6WkZOm+HFbM7z/wq05yCpcZewqRL6Y0PAuPYR/A3d+gePu CtLZAs642OvFYLiMhbyFltwrT/JzYWQ6GQtOy9KZbtHh19KloYDSPkwVvxObQ4/zoiQk nREQ== X-Gm-Message-State: AA+aEWYnaYQA/ktXNb1opSrlEduJmnzdqlF8wSkHdeT3pgqIrTB4QFUS RmKBcuWOjzknBXC5filbzow= X-Google-Smtp-Source: ALg8bN64u1GO0SOpRioLk9AUlNfvpu+YJitkVXkgRILNo4E3FZ/OQinzyDQNOHttQ3DDHw4vfeXsxw== X-Received: by 2002:a62:2292:: with SMTP id p18mr33519493pfj.9.1546109674949; Sat, 29 Dec 2018 10:54:34 -0800 (PST) Received: from [192.168.1.101] (122-58-176-92-adsl.sparkbb.co.nz. [122.58.176.92]) by smtp.gmail.com with ESMTPSA id d3sm56222328pgl.64.2018.12.29.10.54.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Dec 2018 10:54:33 -0800 (PST) Subject: Re: [PATCH v8 01/25] scsi/atari_scsi: Don't select CONFIG_NVRAM To: LEROY Christophe References: <20181228173846.Horde.z_zDEJN0rVd8tkt3HjYzmg2@messagerie.si.c-s.fr>

<20181229175502.Horde.OaGr035vfDpvlvNGdmoaOQ2@messagerie.si.c-s.fr> From: Michael Schmitz Message-ID: Date: Sun, 30 Dec 2018 07:54:24 +1300 User-Agent: Mozilla/5.0 (X11; Linux ppc; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <20181229175502.Horde.OaGr035vfDpvlvNGdmoaOQ2@messagerie.si.c-s.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "James E.J. Bottomley" , Arnd Bergmann , "Martin K. Petersen" , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Finn Thain , linux-m68k@lists.linux-m68k.org, linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Christophe, Am 30.12.2018 um 05:55 schrieb LEROY Christophe: > Michael Schmitz a écrit : > >> Hi Finn, >> >> Am 29.12.2018 um 14:06 schrieb Finn Thain: >>> On Fri, 28 Dec 2018, LEROY Christophe wrote: >>>>> diff --git a/drivers/scsi/atari_scsi.c b/drivers/scsi/atari_scsi.c >>>>> index 89f5154c40b6..99e5729d910d 100644 >>>>> --- a/drivers/scsi/atari_scsi.c >>>>> +++ b/drivers/scsi/atari_scsi.c >>>>> @@ -755,9 +755,10 @@ static int __init atari_scsi_probe(struct >>>>> platform_device *pdev) >>>>> if (ATARIHW_PRESENT(TT_SCSI) && setup_sg_tablesize >= 0) >>>>> atari_scsi_template.sg_tablesize = setup_sg_tablesize; >>>>> >>>>> - if (setup_hostid >= 0) { >>>>> + if (setup_hostid >= 0) >>>>> atari_scsi_template.this_id = setup_hostid & 7; >>>>> - } else { >>>>> +#ifdef CONFIG_NVRAM >>>>> + else >>>> >>>> Such ifdefs should be avoided in C files. >>>> It would be better to use >>>> >>>> } else if (IS_ENABLED(CONFIG_NVRAM)) { >>>> >>> >>> I don't like #ifdefs either. However, as the maintainer of this file, >>> I am >>> okay with this one. >>> >>> The old #ifdef CONFIG_NVRAM conditional compilation convention that gets >>> used here and under drivers/video/fbdev could probably be improved upon >>> but I consider this to be out-of-scope for this series, which is >>> complicated enough. >>> >>> And as explained in the commit log, CONFIG_NVRAM=y and CONFIG_NVRAM=m >>> are >>> treaded differently by drivers. Therefore, IS_ENABLED would be >>> incorrect. >> >> IS_BUILTIN(CONFIG_NVRAM) is probably what Christophe really meant to >> suggest. > > Doesn't #ifdef means either y or m ? So the same as IS_ENABLED() ? #ifdef CONFIG_NVRAM is used if you want to match CONFIG_NVRAM=y. For CONFIG_NVRAM=m, you'd use #ifdef CONFIG_NVRAM_MODULE. Cheers, Michael > > Christophe > >> >> Or (really going out on a limb here): >> >> IS_BUILTIN(CONFIG_NVRAM) || >> ( IS_MODULE(CONFIG_ATARI_SCSI) && IS_ENABLED(CONFIG_NVRAM) ) >> >> Not that I'd advocate that, for this series. >> >> Cheers, >> >> Michael > >