From: Andrew Donnellan <ajd@linux.ibm.com>
To: Russell Currey <ruscur@russell.cc>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org
Cc: nayna@linux.ibm.com, gregkh@linuxfoundation.org,
gcwilson@linux.ibm.com, linux-kernel@vger.kernel.org,
zohar@linux.ibm.com
Subject: Re: [PATCH v2 7/7] powerpc/pseries: Implement secvars for dynamic secure boot
Date: Mon, 09 Jan 2023 16:20:51 +1100 [thread overview]
Message-ID: <cca49d1e5da01e9ccdee50d710045fd09005459c.camel@linux.ibm.com> (raw)
In-Reply-To: <b4b23fb8a56fdcfffe28c38ac3f4f89e0c488486.camel@russell.cc>
On Mon, 2023-01-09 at 14:34 +1100, Russell Currey wrote:
>
> > > +static int plpks_secvar_init(void)
> > > +{
> > > + if (!plpks_is_available())
> > > + return -ENODEV;
> > > +
> > > + set_secvar_ops(&plpks_secvar_ops);
> > > + set_secvar_config_attrs(config_attrs);
> > > + return 0;
> > > +}
> > > +device_initcall(plpks_secvar_init);
> >
> > That must be a machine_device_initcall(pseries, ...), otherwise we
> > will
> > blow up doing a hcall on powernv in plpks_is_available().
>
> OK, can do. I don't understand your case of how powernv could hit
> this, but I think I to have to move plpks_is_available() into
> include/,
> so it's going to be even more possible anyway.
Kernels can be compiled with both pseries and powernv support, in which
case plpks_secvar_init() will be called unconditionally even when
booting on a powernv machine.
I can confirm that as it is, booting this on powernv qemu causes a
panic.
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2023-01-09 5:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 4:20 [PATCH v2 0/7] pseries dynamic secure boot interface using secvar Russell Currey
2022-12-30 4:20 ` [PATCH v2 1/7] powerpc/pseries: Log hcall return codes for PLPKS debug Russell Currey
2023-01-04 4:45 ` Andrew Donnellan
2022-12-30 4:20 ` [PATCH v2 2/7] powerpc/secvar: WARN_ON_ONCE() if multiple secvar ops are set Russell Currey
2023-01-04 7:10 ` Andrew Donnellan
2022-12-30 4:20 ` [PATCH v2 3/7] powerpc/secvar: Use sysfs_emit() instead of sprintf() Russell Currey
2023-01-04 7:12 ` Andrew Donnellan
2022-12-30 4:20 ` [PATCH v2 4/7] powerpc/secvar: Handle format string in the consumer Russell Currey
2023-01-04 7:31 ` Andrew Donnellan
2022-12-30 4:20 ` [PATCH v2 5/7] powerpc/secvar: Handle max object size " Russell Currey
2023-01-04 7:50 ` Andrew Donnellan
2022-12-30 4:20 ` [PATCH v2 6/7] powerpc/secvar: Extend sysfs to include config vars Russell Currey
2023-01-05 7:28 ` Andrew Donnellan
2023-01-06 6:33 ` Russell Currey
2023-01-06 4:15 ` Michael Ellerman
2023-01-06 6:35 ` Russell Currey
2022-12-30 4:20 ` [PATCH v2 7/7] powerpc/pseries: Implement secvars for dynamic secure boot Russell Currey
2023-01-05 8:15 ` Andrew Donnellan
2023-01-06 6:49 ` Russell Currey
2023-01-09 4:42 ` Andrew Donnellan
2023-01-06 10:49 ` Michael Ellerman
2023-01-09 3:33 ` Andrew Donnellan
2023-01-09 3:34 ` Russell Currey
2023-01-09 5:20 ` Andrew Donnellan [this message]
2023-01-10 1:27 ` Russell Currey
2023-01-10 3:59 ` Andrew Donnellan
2023-01-11 3:57 ` Andrew Donnellan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cca49d1e5da01e9ccdee50d710045fd09005459c.camel@linux.ibm.com \
--to=ajd@linux.ibm.com \
--cc=gcwilson@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nayna@linux.ibm.com \
--cc=ruscur@russell.cc \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).