From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: "Pali Rohár" <pali@kernel.org>
Cc: Sinan Akman <sinan@writeme.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
Scott Wood <oss@buserror.net>,
Martin Kennedy <hurricos@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 0/8] powerpc/85xx: p2020: Create one unified machine description
Date: Mon, 13 Feb 2023 19:58:15 +0000 [thread overview]
Message-ID: <ceb80ec7-57cc-ba39-88f9-72fc8fa67930@csgroup.eu> (raw)
In-Reply-To: <20230209001507.nc2njllc32pjp2az@pali>
Le 09/02/2023 à 01:15, Pali Rohár a écrit :
>>
>> This patch moves all p2020 boards from mpc85xx_rdb.c and mpc85xx_ds.c
>> files into new p2020.c file, and plus it copies all helper functions
>> which p2020 boards requires. This patch does not introduce any new code
>> or functional change. It should be really plain copy/move.
Yes after looking into it in more details, it is exactly that. You
copied all helper functions but this is not said in the commit message.
I think it should be said, and more important it should be explained why.
Because this is exactly what I was not understanding, why I couldn't see
all moved functions: just because many of them were not moved but copied.
In the two first pages you made some function static, and then you
duplicated it. Why ? Why not keep it global and just use it from one
place to the other ?
Because after patch 3 we have:
arch/powerpc/platforms/85xx/mpc85xx_rdb.c:static void __init
mpc85xx_rdb_pic_init(void)
arch/powerpc/platforms/85xx/p2020.c:static void __init
mpc85xx_rdb_pic_init(void)
arch/powerpc/platforms/85xx/mpc85xx_ds.c:static void __init
mpc85xx_ds_pic_init(void)
arch/powerpc/platforms/85xx/p2020.c:static void __init
mpc85xx_ds_pic_init(void)
Why not just drop patches 1 and 2 and keep those two functions and all
the other common functions like mpc85xx_8259_cascade()
mpc85xx_ds_uli_init() and a lot more in a separate common file ?
Christophe
next prev parent reply other threads:[~2023-02-13 19:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-24 21:14 [PATCH v2 0/8] powerpc/85xx: p2020: Create one unified machine description Pali Rohár
2022-12-24 21:14 ` [PATCH v2 1/8] powerpc/85xx: Mark mpc85xx_rdb_pic_init() as static Pali Rohár
2022-12-24 21:14 ` [PATCH v2 2/8] powerpc/85xx: Mark mpc85xx_ds_pic_init() " Pali Rohár
2022-12-24 21:14 ` [PATCH v2 3/8] powerpc/85xx: p2020: Move all P2020 machine descriptions to p2020.c Pali Rohár
2023-02-03 19:08 ` Pali Rohár
2023-02-13 20:05 ` Christophe Leroy
2023-02-13 20:15 ` Pali Rohár
2023-02-14 5:49 ` Christophe Leroy
2022-12-24 21:14 ` [PATCH v2 4/8] powerpc/85xx: p2020: Move i8259 code into own function Pali Rohár
2023-02-13 20:06 ` Christophe Leroy
2023-02-13 20:17 ` Pali Rohár
2022-12-24 21:14 ` [PATCH v2 5/8] powerpc/85xx: p2020: Unify .setup_arch and .init_IRQ callbacks Pali Rohár
2022-12-24 21:14 ` [PATCH v2 6/8] powerpc/85xx: p2020: Define just one machine description Pali Rohár
2023-02-13 20:08 ` Christophe Leroy
2023-02-13 20:18 ` Pali Rohár
2022-12-24 21:14 ` [PATCH v2 7/8] powerpc/85xx: p2020: Enable boards by new config option CONFIG_PPC_P2020 Pali Rohár
2022-12-24 21:14 ` [PATCH v2 8/8] powerpc: dts: turris1x.dts: Remove "fsl,P2020RDB-PC" compatible string Pali Rohár
2023-01-22 11:16 ` [PATCH v2 0/8] powerpc/85xx: p2020: Create one unified machine description Pali Rohár
2023-01-23 14:32 ` Christophe Leroy
2023-01-23 20:09 ` Pali Rohár
2023-02-09 0:15 ` Pali Rohár
2023-02-13 19:58 ` Christophe Leroy [this message]
2023-02-13 20:11 ` Pali Rohár
2023-02-14 5:47 ` Christophe Leroy
2023-02-15 18:57 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceb80ec7-57cc-ba39-88f9-72fc8fa67930@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=hurricos@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=oss@buserror.net \
--cc=pali@kernel.org \
--cc=sinan@writeme.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).