From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52EE8C433F5 for ; Fri, 29 Oct 2021 01:03:37 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC9EF61106 for ; Fri, 29 Oct 2021 01:03:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CC9EF61106 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HgPLv2dcZz3c50 for ; Fri, 29 Oct 2021 12:03:35 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=Y9ted3wn; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::130; helo=mail-lf1-x130.google.com; envelope-from=digetx@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=Y9ted3wn; dkim-atps=neutral Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HgJly4dv6z2xth; Fri, 29 Oct 2021 08:36:30 +1100 (AEDT) Received: by mail-lf1-x130.google.com with SMTP id p16so16525342lfa.2; Thu, 28 Oct 2021 14:36:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=thttoNtx85IqBzMI/c95u4NQI+WEGNQqD09v61bWPkE=; b=Y9ted3wnUvFPZbztZa+QHRbohuO2ujzfF68/pFicW5dA7D1yuFrKCL4aTWk/1AChzB fKwgUocsDwuNOGM2+iseiHe/bj2d1v3+dSRNtXKqEmTsyBkz7IWQs8pVvc2a2gvGjfup yLqAO4u/w7mjCphm/lBZwptgCTPupkSC+307KKr7OHU7po5AtPQB8ZhrguBiu6yERIjH bK0WN85VLNpdVAhT7soiJpVcCZ4Sp0KIHJV14Uu8RloVE9YJBCz/nPhBHDPyGgkjYHQ0 imoJdP8GopH3zoQfTkWNgL4xsg20XHFvSLev9dZQthSUfjSrDblQ5bVzKxHiquLI0ZeF 3ufg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=thttoNtx85IqBzMI/c95u4NQI+WEGNQqD09v61bWPkE=; b=OPhu4PU2ftB1WjYyUDNUuw2y2cE3IrMHATxBHOJDyEFWPXofaFZPyd3e9kA9gdYpwj iLE42f5sIS0xhoLc9WV0w7z7yAj+9oltG9A6SyVfEI4C1O1YMB62snim7/CQla/A4jf4 mCX8MAwT5fPSkrH2+1+fuj1ysMUUd/fVZ51IuUDjVy03gP1A8vVUW75y4U1RiUe1A1IL PVptR1DCrMF9IsiQ0AId3h3+DyUyS850Us6wQTUppfDjYbCOAsYPh0oSZUfldRmW44xJ jGJqLwPPBLB82n9FQh1FRSbygQfz/rn2HrI+RYd7+rPQ+kLIPDPuxBiPFwDdxh9wn5mo dUig== X-Gm-Message-State: AOAM531WkS9/ELrQ4JWdlB9PO6GsdNMfBLURhJsF59+3b1zQSz4dEzl4 bxMzbWhrh3iyG3h8RkdmAzU= X-Google-Smtp-Source: ABdhPJzbYSC0nWI15MXaoXJe2SikVhRJRnLxoLeSiSPsVfPjrcP1DbWpe0jTqiEw6MLnleJHOc1O3g== X-Received: by 2002:a05:6512:2292:: with SMTP id f18mr6437448lfu.619.1635456985989; Thu, 28 Oct 2021 14:36:25 -0700 (PDT) Received: from [192.168.2.145] (46-138-44-18.dynamic.spd-mgts.ru. [46.138.44.18]) by smtp.googlemail.com with ESMTPSA id s9sm396521ljg.76.2021.10.28.14.36.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Oct 2021 14:36:25 -0700 (PDT) Subject: Re: [PATCH v2 08/45] kernel: Add combined power-off+restart handler call chain API To: "Rafael J. Wysocki" References: <20211027211715.12671-1-digetx@gmail.com> <20211027211715.12671-9-digetx@gmail.com> From: Dmitry Osipenko Message-ID: Date: Fri, 29 Oct 2021 00:36:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Fri, 29 Oct 2021 12:02:21 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Rich Felker , linux-ia64@vger.kernel.org, Tomer Maimon , Santosh Shilimkar , Linux-sh list , Boris Ostrovsky , Catalin Marinas , Linus Walleij , Dave Hansen , the arch/x86 maintainers , Tali Perry , "James E.J. Bottomley" , Thierry Reding , Guo Ren , Pavel Machek , "H. Peter Anvin" , linux-riscv@lists.infradead.org, Vincent Chen , Will Deacon , Greg Ungerer , Stefano Stabellini , Benjamin Fair , Yoshinori Sato , Krzysztof Kozlowski , Lee Jones , Helge Deller , Daniel Lezcano , Russell King , linux-csky@vger.kernel.org, Jonathan Hunter , Tony Lindgren , Chen-Yu Tsai , Ingo Molnar , Geert Uytterhoeven , xen-devel@lists.xenproject.org, linux-mips@vger.kernel.org, Guenter Roeck , Len Brown , Albert Ou , Linux OMAP Mailing List , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Vladimir Zapolskiy , ACPI Devel Maling List , linux-m68k@lists.linux-m68k.org, Mark Brown , Borislav Petkov , Greentime Hu , Paul Walmsley , linux-tegra , Thomas Gleixner , Andy Shevchenko , Nancy Yuen , Linux ARM , Juergen Gross , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, Nick Hu , Avi Fishman , Patrick Venture , Linux PM , Liam Girdwood , Linux Kernel Mailing List , Palmer Dabbelt , Philipp Zabel , Paul Mackerras , Andrew Morton , linuxppc-dev , openbmc@lists.ozlabs.org, Joshua Thompson Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" 28.10.2021 12:53, Rafael J. Wysocki пишет: >> +/** >> + * struct power_handler - Machine power-off + restart handler >> + * >> + * Describes power-off and restart handlers which are invoked by kernel >> + * to power off or restart this machine. Supports prioritized chaining for >> + * both restart and power-off handlers. Callback's priority must be unique. >> + * Intended to be used by device drivers that are responsible for restarting >> + * and powering off hardware which kernel is running on. >> + * >> + * Struct power_handler can be static. Members of this structure must not be >> + * altered while handler is registered. >> + * >> + * Fill the structure members and pass it to register_power_handler(). >> + */ >> +struct power_handler { > The name of this structure is too generic IMV. There are many things > that it might apply to in principle. > > What about calling power_off_handler or sys_off_handler as it need not > be about power at all? I didn't like much the 'power' either, but couldn't come up with a better variant. Will change it in v3, thank you.