From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: "linux-xtensa@linux-xtensa.org" <linux-xtensa@linux-xtensa.org>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
"linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-um@lists.infradead.org" <linux-um@lists.infradead.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"linux-csky@vger.kernel.org" <linux-csky@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"linux-m68k@lists.linux-m68k.org"
<linux-m68k@lists.linux-m68k.org>,
"openrisc@lists.librecores.org" <openrisc@lists.librecores.org>,
"linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-snps -arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V4 02/26] mm/mmap: Define DECLARE_VM_GET_PAGE_PROT
Date: Fri, 24 Jun 2022 05:28:48 +0000 [thread overview]
Message-ID: <d3676fce-2dc7-6331-66f5-7009ac45f605@csgroup.eu> (raw)
In-Reply-To: <20220624044339.1533882-3-anshuman.khandual@arm.com>
Le 24/06/2022 à 06:43, Anshuman Khandual a écrit :
> This just converts the generic vm_get_page_prot() implementation into a new
> macro i.e DECLARE_VM_GET_PAGE_PROT which later can be used across platforms
> when enabling them with ARCH_HAS_VM_GET_PAGE_PROT. This does not create any
> functional change.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Suggested-by: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> include/linux/mm.h | 8 ++++++++
> mm/mmap.c | 6 +-----
> 2 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 47bfe038d46e..237828c2bae2 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -428,6 +428,14 @@ extern unsigned int kobjsize(const void *objp);
> extern pgprot_t protection_map[16];
> #endif
>
I think the comment above protection_map[16] in mm/mmap.c should be
moved here.
> +#define DECLARE_VM_GET_PAGE_PROT \
> +pgprot_t vm_get_page_prot(unsigned long vm_flags) \
> +{ \
> + return protection_map[vm_flags & \
> + (VM_READ | VM_WRITE | VM_EXEC | VM_SHARED)]; \
> +} \
> +EXPORT_SYMBOL(vm_get_page_prot);
> +
> /*
> * The default fault flags that should be used by most of the
> * arch-specific page fault handlers.
> diff --git a/mm/mmap.c b/mm/mmap.c
> index b01f0280bda2..55c30aee3999 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -123,11 +123,7 @@ pgprot_t protection_map[16] __ro_after_init = {
> #endif
>
> #ifndef CONFIG_ARCH_HAS_VM_GET_PAGE_PROT
> -pgprot_t vm_get_page_prot(unsigned long vm_flags)
> -{
> - return protection_map[vm_flags & (VM_READ|VM_WRITE|VM_EXEC|VM_SHARED)];
> -}
> -EXPORT_SYMBOL(vm_get_page_prot);
> +DECLARE_VM_GET_PAGE_PROT
> #endif /* CONFIG_ARCH_HAS_VM_GET_PAGE_PROT */
>
> static pgprot_t vm_pgprot_modify(pgprot_t oldprot, unsigned long vm_flags)
next prev parent reply other threads:[~2022-06-24 5:29 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 4:43 [PATCH V4 00/26] mm/mmap: Drop __SXXX/__PXXX macros from across platforms Anshuman Khandual
2022-06-24 4:43 ` [PATCH V4 01/26] mm/mmap: Build protect protection_map[] with __P000 Anshuman Khandual
2022-06-24 5:08 ` Christoph Hellwig
2022-06-27 5:47 ` Christophe Leroy
2022-06-24 4:43 ` [PATCH V4 02/26] mm/mmap: Define DECLARE_VM_GET_PAGE_PROT Anshuman Khandual
2022-06-24 5:09 ` Christoph Hellwig
2022-06-24 6:09 ` Anshuman Khandual
2022-06-24 5:28 ` Christophe Leroy [this message]
2022-06-24 6:11 ` Anshuman Khandual
2022-06-27 5:47 ` Christophe Leroy
2022-06-24 4:43 ` [PATCH V4 03/26] powerpc/mm: Move protection_map[] inside the platform Anshuman Khandual
2022-06-24 5:18 ` Christophe Leroy
2022-06-24 5:23 ` Anshuman Khandual
2022-06-27 5:48 ` Christophe Leroy
2022-06-24 4:43 ` [PATCH V4 04/26] sparc/mm: " Anshuman Khandual
2022-06-24 4:43 ` [PATCH V4 05/26] arm64/mm: " Anshuman Khandual
2022-06-24 12:24 ` Catalin Marinas
2022-06-24 4:43 ` [PATCH V4 06/26] x86/mm: " Anshuman Khandual
2022-06-24 5:10 ` Christoph Hellwig
2022-06-24 4:43 ` [PATCH V4 07/26] mm/mmap: Build protect protection_map[] with ARCH_HAS_VM_GET_PAGE_PROT Anshuman Khandual
2022-06-24 5:22 ` Christophe Leroy
2022-06-24 5:36 ` Anshuman Khandual
2022-06-27 5:48 ` Christophe Leroy
2022-06-24 4:43 ` [PATCH V4 08/26] microblaze/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT Anshuman Khandual
2022-06-24 5:24 ` Christophe Leroy
2022-06-24 4:43 ` [PATCH V4 09/26] loongarch/mm: " Anshuman Khandual
2022-06-24 4:43 ` [PATCH V4 10/26] openrisc/mm: " Anshuman Khandual
2022-06-25 4:04 ` Stafford Horne
2022-06-24 4:43 ` [PATCH V4 11/26] extensa/mm: " Anshuman Khandual
2022-06-24 4:43 ` [PATCH V4 12/26] hexagon/mm: " Anshuman Khandual
2022-06-24 4:43 ` [PATCH V4 13/26] parisc/mm: " Anshuman Khandual
2022-06-24 4:43 ` [PATCH V4 14/26] alpha/mm: " Anshuman Khandual
2022-06-24 4:43 ` [PATCH V4 15/26] nios2/mm: " Anshuman Khandual
2022-06-24 4:43 ` [PATCH V4 16/26] riscv/mm: " Anshuman Khandual
2022-06-24 5:10 ` Christoph Hellwig
2022-06-24 4:43 ` [PATCH V4 17/26] csky/mm: " Anshuman Khandual
2022-06-25 3:07 ` Guo Ren
2022-06-24 4:43 ` [PATCH V4 18/26] s390/mm: " Anshuman Khandual
2022-06-24 4:43 ` [PATCH V4 19/26] ia64/mm: " Anshuman Khandual
2022-06-24 4:43 ` [PATCH V4 20/26] mips/mm: " Anshuman Khandual
2022-06-24 4:43 ` [PATCH V4 21/26] m68k/mm: " Anshuman Khandual
2022-06-24 4:43 ` [PATCH V4 22/26] arc/mm: " Anshuman Khandual
2022-06-24 4:43 ` [PATCH V4 23/26] arm/mm: " Anshuman Khandual
2022-06-24 4:43 ` [PATCH V4 24/26] um/mm: " Anshuman Khandual
2022-06-24 4:43 ` [PATCH V4 25/26] sh/mm: " Anshuman Khandual
2022-06-24 4:43 ` [PATCH V4 26/26] mm/mmap: Drop ARCH_HAS_VM_GET_PAGE_PROT Anshuman Khandual
2022-06-24 5:11 ` Christoph Hellwig
2022-06-24 5:29 ` Christophe Leroy
2022-06-27 5:48 ` Christophe Leroy
2022-06-24 5:12 ` [PATCH V4 00/26] mm/mmap: Drop __SXXX/__PXXX macros from across platforms Christoph Hellwig
2022-06-24 5:20 ` Anshuman Khandual
2022-06-24 5:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3676fce-2dc7-6331-66f5-7009ac45f605@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=hch@infradead.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=openrisc@lists.librecores.org \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).