From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Nicholas Piggin <npiggin@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH v2 6/7] powerpc/64/build: merge .got and .toc input sections
Date: Fri, 16 Sep 2022 18:45:17 +0000 [thread overview]
Message-ID: <d54b206c-0254-9def-d558-50c82a89f461@csgroup.eu> (raw)
In-Reply-To: <20220916040755.2398112-7-npiggin@gmail.com>
Le 16/09/2022 à 06:07, Nicholas Piggin a écrit :
> Follow the binutils ld internal linker script and merge .got and .toc
> input sections in the .got output section.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> arch/powerpc/kernel/vmlinux.lds.S | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/vmlinux.lds.S b/arch/powerpc/kernel/vmlinux.lds.S
> index 737825ae2ae0..3d96d51c8a5f 100644
> --- a/arch/powerpc/kernel/vmlinux.lds.S
> +++ b/arch/powerpc/kernel/vmlinux.lds.S
> @@ -169,13 +169,12 @@ SECTIONS
> }
>
> .got : AT(ADDR(.got) - LOAD_OFFSET) ALIGN(256) {
> - *(.got)
> + *(.got .toc)
At the begining I was thinking that this change would jeopardise the
below, but in fact the #ifdef below is pointless, because prom_init.o is
built only when CONFIG_PPC_OF_BOOT_TRAMPOLINE is selected but
CONFIG_PPC_OF_BOOT_TRAMPOLINE selects CONFIG_RELOCATABLE
So all __prom_init_toc_ stuff can go away :
arch/powerpc/include/asm/sections.h:extern char __prom_init_toc_start[];
arch/powerpc/include/asm/sections.h:extern char __prom_init_toc_end[];
arch/powerpc/kernel/prom_init_check.sh:__prom_init_toc_start
__prom_init_toc_end btext_setup_display TOC.
arch/powerpc/kernel/vmlinux.lds.S: __prom_init_toc_start = .;
arch/powerpc/kernel/vmlinux.lds.S: __prom_init_toc_end = .;
> #ifndef CONFIG_RELOCATABLE
> __prom_init_toc_start = .;
> arch/powerpc/kernel/prom_init.o*(.toc)
> __prom_init_toc_end = .;
> #endif
> - *(.toc)
> }
>
> SOFT_MASK_TABLE(8)
next prev parent reply other threads:[~2022-09-16 18:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 4:07 [PATCH v2 0/7] powerpc: build / linker improvements Nicholas Piggin
2022-09-16 4:07 ` [PATCH v2 1/7] powerpc: move __end_rodata to cover arch read-only sections Nicholas Piggin
2022-09-16 4:07 ` [PATCH v2 2/7] powerpc/32/build: move got1/got2 sections out of text Nicholas Piggin
2022-09-16 4:07 ` [PATCH v2 3/7] powerpc/build: move got, toc, plt, branch_lt sections to read-only Nicholas Piggin
2022-09-17 20:15 ` kernel test robot
2022-09-19 5:39 ` Michael Ellerman
2022-09-20 10:50 ` Nicholas Piggin
2022-09-16 4:07 ` [PATCH v2 4/7] powerpc/build: move .data.rel.ro, .sdata2 " Nicholas Piggin
2022-09-16 4:07 ` [PATCH v2 5/7] powerpc/64/build: only include .opd with ELFv1 Nicholas Piggin
2022-09-16 4:07 ` [PATCH v2 6/7] powerpc/64/build: merge .got and .toc input sections Nicholas Piggin
2022-09-16 18:45 ` Christophe Leroy [this message]
2022-09-17 6:36 ` Michael Ellerman
2022-09-16 4:07 ` [PATCH v2 7/7] powerpc/build: put sys_call_table in .data.rel.ro if RELOCATABLE Nicholas Piggin
2022-10-04 13:24 ` [PATCH v2 0/7] powerpc: build / linker improvements Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d54b206c-0254-9def-d558-50c82a89f461@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).