From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8048FC32753 for ; Wed, 14 Aug 2019 11:13:47 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 099422083B for ; Wed, 14 Aug 2019 11:13:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 099422083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 467n5N0fYYzDql6 for ; Wed, 14 Aug 2019 21:13:44 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 467n2c1xjhzDq6N for ; Wed, 14 Aug 2019 21:11:20 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by bilbo.ozlabs.org (Postfix) with ESMTP id 467n2b5b5Cz8tTq for ; Wed, 14 Aug 2019 21:11:19 +1000 (AEST) Received: by ozlabs.org (Postfix) id 467n2b44DWz9sN1; Wed, 14 Aug 2019 21:11:19 +1000 (AEST) Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=hbathini@linux.ibm.com; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 467n2b062bz9sNp for ; Wed, 14 Aug 2019 21:11:18 +1000 (AEST) Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7EB6gt3063157 for ; Wed, 14 Aug 2019 07:11:15 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ucfjsc3f6-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 14 Aug 2019 07:11:15 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 14 Aug 2019 12:11:13 +0100 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 14 Aug 2019 12:11:10 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x7EBB8qa15663420 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Aug 2019 11:11:08 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4B950AE057; Wed, 14 Aug 2019 11:11:08 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 15F79AE045; Wed, 14 Aug 2019 11:11:06 +0000 (GMT) Received: from [9.199.56.240] (unknown [9.199.56.240]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 14 Aug 2019 11:11:05 +0000 (GMT) Subject: Re: [PATCH v4 14/25] powernv/fadump: process the crashdump by exporting it as /proc/vmcore To: mahesh@linux.vnet.ibm.com References: <156327668777.27462.5297279227799429100.stgit@hbathini.in.ibm.com> <156327681824.27462.1314030665685342118.stgit@hbathini.in.ibm.com> <20190814101801.tbzqbds3n4qf5wey@in.ibm.com> From: Hari Bathini Date: Wed, 14 Aug 2019 16:41:04 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190814101801.tbzqbds3n4qf5wey@in.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19081411-4275-0000-0000-00000359115F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19081411-4276-0000-0000-0000386B243E Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-08-14_04:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=874 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908140116 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ananth N Mavinakayanahalli , Mahesh J Salgaonkar , Vasant Hegde , linuxppc-dev , Oliver , Nicholas Piggin , Stewart Smith , Daniel Axtens Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 14/08/19 3:48 PM, Mahesh J Salgaonkar wrote: > On 2019-07-16 17:03:38 Tue, Hari Bathini wrote: >> Add support in the kernel to process the crash'ed kernel's memory >> preserved during MPIPL and export it as /proc/vmcore file for the >> userland scripts to filter and analyze it later. >> >> Signed-off-by: Hari Bathini >> --- >> arch/powerpc/platforms/powernv/opal-fadump.c | 190 ++++++++++++++++++++++++++ >> 1 file changed, 187 insertions(+), 3 deletions(-) >> > [...] >> + ret = opal_mpipl_query_tag(OPAL_MPIPL_TAG_KERNEL, &addr); >> + if ((ret != OPAL_SUCCESS) || !addr) { >> + pr_err("Failed to get Kernel metadata (%lld)\n", ret); >> + return 1; >> + } >> + >> + addr = be64_to_cpu(addr); >> + pr_debug("Kernel metadata addr: %llx\n", addr); >> + >> + opal_fdm_active = __va(addr); >> + r_opal_fdm_active = (void *)addr; >> + if (r_opal_fdm_active->version != OPAL_FADUMP_VERSION) { >> + pr_err("FADump active but version (%u) unsupported!\n", >> + r_opal_fdm_active->version); >> + return 1; >> + } >> + >> + /* Kernel regions not registered with f/w for MPIPL */ >> + if (r_opal_fdm_active->registered_regions == 0) { >> + opal_fdm_active = NULL; > > What about partial dump capture scenario ? What if opal crashes while > kernel was in middle of registering ranges ? We may have partial dump > captured which won't be useful. > e,g. If we have total of 4 ranges to be registered and opal crashes > after successful registration of only 2 ranges with 2 pending, we will get a > partial dump which needs to be ignored. > > I think check shuold be comparing registered_regions against total number of > regions. What do you think ? Yes, Mahesh. Taking care of that in 22/25 Thanks Hari