From: Jens Axboe <axboe@kernel.dk>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Jim Paris <jim@jtan.com>, Geoff Levand <geoff@infradead.org>,
Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] block/ps3vram: Use %llu to format sector_t after LBDAF removal
Date: Thu, 13 Jun 2019 03:18:01 -0600 [thread overview]
Message-ID: <da98e8b2-8abf-77c1-ac98-6b164ebf9d34@kernel.dk> (raw)
In-Reply-To: <20190613073006.13459-1-geert+renesas@glider.be>
On 6/13/19 1:30 AM, Geert Uytterhoeven wrote:
> The removal of CONFIG_LBDAF changed the type of sector_t from "unsigned
> long" to "u64" aka "unsigned long long" on 64-bit platforms, leading to
> a compiler warning regression:
>
> drivers/block/ps3vram.c: In function ‘ps3vram_probe’:
> drivers/block/ps3vram.c:770:23: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘sector_t {aka long long unsigned int}’ [-Wformat=]
>
> Fix this by using "%llu" instead.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2019-06-13 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 7:30 [PATCH] block/ps3vram: Use %llu to format sector_t after LBDAF removal Geert Uytterhoeven
2019-06-13 9:18 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da98e8b2-8abf-77c1-ac98-6b164ebf9d34@kernel.dk \
--to=axboe@kernel.dk \
--cc=geert+renesas@glider.be \
--cc=geoff@infradead.org \
--cc=hch@lst.de \
--cc=jim@jtan.com \
--cc=linux-block@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).