From: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
To: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
npiggin@gmail.com
Subject: Re: [PATCH] powerpc/xmon: Fix an unexpected xmon onoff state change
Date: Wed, 15 Feb 2017 19:22:16 -0200 [thread overview]
Message-ID: <e09792c7-585f-783f-7924-19eb4c8af871@linux.vnet.ibm.com> (raw)
In-Reply-To: <1487144990-5969-1-git-send-email-xinhui.pan@linux.vnet.ibm.com>
On 15/02/2017 05:49, Pan Xinhui wrote:
> Once xmon is triggered by sysrq-x, it is enabled always afterwards even
> if it is disabled during boot. This will cause a system reset interrut
> fail to dump. So keep xmon in its original state after exit.
>
> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
Patch is fine - minor typo: interrut => interrupt
Feel free to add my:
Tested-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Thanks,
Guilherme
> ---
> arch/powerpc/xmon/xmon.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
> index 9c0e17c..721212f 100644
> --- a/arch/powerpc/xmon/xmon.c
> +++ b/arch/powerpc/xmon/xmon.c
> @@ -76,6 +76,7 @@ static int xmon_gate;
> #endif /* CONFIG_SMP */
>
> static unsigned long in_xmon __read_mostly = 0;
> +static int xmon_off = 0;
>
> static unsigned long adrs;
> static int size = 1;
> @@ -3250,6 +3251,8 @@ static void sysrq_handle_xmon(int key)
> /* ensure xmon is enabled */
> xmon_init(1);
> debugger(get_irq_regs());
> + if (xmon_off)
> + xmon_init(0);
> }
>
> static struct sysrq_key_op sysrq_xmon_op = {
> @@ -3266,7 +3269,7 @@ static int __init setup_xmon_sysrq(void)
> __initcall(setup_xmon_sysrq);
> #endif /* CONFIG_MAGIC_SYSRQ */
>
> -static int __initdata xmon_early, xmon_off;
> +static int __initdata xmon_early;
>
> static int __init early_parse_xmon(char *p)
> {
>
next prev parent reply other threads:[~2017-02-15 21:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 7:49 [PATCH] powerpc/xmon: Fix an unexpected xmon onoff state change Pan Xinhui
2017-02-15 21:22 ` Guilherme G. Piccoli [this message]
2017-02-16 5:09 ` Michael Ellerman
2017-02-16 10:57 ` Guilherme G. Piccoli
2017-02-16 11:51 ` Pan Xinhui
2017-02-17 6:05 ` Michael Ellerman
2017-02-17 9:30 ` Pan Xinhui
2017-02-17 12:25 ` Guilherme G. Piccoli
2017-02-20 4:46 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e09792c7-585f-783f-7924-19eb4c8af871@linux.vnet.ibm.com \
--to=gpiccoli@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=xinhui.pan@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).