From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, npiggin@gmail.com
Subject: [PATCH] powerpc: Fix HMIs on big-endian with CONFIG_RELOCATABLE=y
Date: Mon, 08 Oct 2018 15:08:31 +1100 [thread overview]
Message-ID: <e4bfa53ea8c777105359e1770df906909dde2c57.camel@kernel.crashing.org> (raw)
HMIs will crash the kernel due to
BRANCH_LINK_TO_FAR(hmi_exception_realmode)
Calling into the OPD instead of the actual code.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
This hack fixes it for me, but it's not great. Nick, any better idea ?
diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
index ea04dfb..752709cc8 100644
--- a/arch/powerpc/kernel/exceptions-64s.S
+++ b/arch/powerpc/kernel/exceptions-64s.S
@@ -1119,7 +1119,11 @@ TRAMP_REAL_BEGIN(hmi_exception_early)
EXCEPTION_PROLOG_COMMON_2(PACA_EXGEN)
EXCEPTION_PROLOG_COMMON_3(0xe60)
addi r3,r1,STACK_FRAME_OVERHEAD
+#ifdef PPC64_ELF_ABI_v1
+ BRANCH_LINK_TO_FAR(.hmi_exception_realmode) /* Function call ABI */
+#else
BRANCH_LINK_TO_FAR(hmi_exception_realmode) /* Function call ABI */
+#endif
cmpdi cr0,r3,0
/* Windup the stack. */
next reply other threads:[~2018-10-08 4:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 4:08 Benjamin Herrenschmidt [this message]
2018-10-08 7:04 ` [PATCH] powerpc: Fix HMIs on big-endian with CONFIG_RELOCATABLE=y Nicholas Piggin
2018-10-08 9:53 ` Benjamin Herrenschmidt
2018-10-09 10:37 ` Michael Ellerman
2018-10-09 12:27 ` Benjamin Herrenschmidt
2018-12-23 13:28 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4bfa53ea8c777105359e1770df906909dde2c57.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).