From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21B42C4360C for ; Thu, 26 Sep 2019 17:18:02 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD62C222C7 for ; Thu, 26 Sep 2019 17:18:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD62C222C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46fM7q2xGRzDqsZ for ; Fri, 27 Sep 2019 03:17:59 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=fbarrat@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46fM5Z6TQYzDqpr for ; Fri, 27 Sep 2019 03:16:02 +1000 (AEST) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x8QHEjCv091729 for ; Thu, 26 Sep 2019 13:15:55 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0b-001b2d01.pphosted.com with ESMTP id 2v9185gqsm-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 26 Sep 2019 13:15:54 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Sep 2019 18:15:53 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 26 Sep 2019 18:15:51 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x8QHFo2n59179088 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Sep 2019 17:15:50 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 05F4C52057; Thu, 26 Sep 2019 17:15:50 +0000 (GMT) Received: from bali.tls.ibm.com (unknown [9.101.4.17]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id B86DA52051; Thu, 26 Sep 2019 17:15:49 +0000 (GMT) Subject: Re: [PATCH 01/11] powerpc/powernv/ioda: Fix ref count for devices with their own PE To: Andrew Donnellan , linuxppc-dev@lists.ozlabs.org, andrew.donnellan@au1.ibm.com, clombard@linux.ibm.com References: <20190909154600.19917-1-fbarrat@linux.ibm.com> <20190909154600.19917-2-fbarrat@linux.ibm.com> <66f8a321-2d6e-dc82-26e1-7f6d9292470a@linux.ibm.com> From: Frederic Barrat Date: Thu, 26 Sep 2019 19:15:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <66f8a321-2d6e-dc82-26e1-7f6d9292470a@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19092617-4275-0000-0000-0000036B8642 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19092617-4276-0000-0000-0000387E05CD Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-09-26_07:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=792 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909260146 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: groug@kaod.org, alastair@au1.ibm.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 26/09/2019 à 18:44, Andrew Donnellan a écrit : > On 9/9/19 5:45 pm, Frederic Barrat wrote: >> Taking a reference on the pci_dev structure was required with initial >> commit 184cd4a3b962 ("powerpc/powernv: PCI support for p7IOC under >> OPAL v2"), where we were storing the pci_dev in the pci_dn structure. >> >> However, the pci_dev was later removed from the pci_dn structure, but >> the reference was kept. See commit 902bdc57451c ("powerpc/powernv/idoa: >> Remove unnecessary pcidev from pci_dn"). >> >> The pnv_ioda_pe structure life cycle is the same as the pci_dev >> structure, the PE is freed when the device is released. So we don't >> need a reference for the pci_dev stored in the PE, otherwise the >> pci_dev will never be released. Which is not really a surprise as the >> comment (removed here as no longer needed) was stating as much. >> >> Fixes: 902bdc57451c ("powerpc/powernv/idoa: Remove unnecessary pcidev >> from pci_dn") >> Signed-off-by: Frederic Barrat >> --- >> arch/powerpc/platforms/powernv/pci-ioda.c | 11 +---------- >> 1 file changed, 1 insertion(+), 10 deletions(-) >> >> diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c >> b/arch/powerpc/platforms/powernv/pci-ioda.c >> index d8080558d020..92767f006f20 100644 >> --- a/arch/powerpc/platforms/powernv/pci-ioda.c >> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c >> @@ -1062,14 +1062,6 @@ static struct pnv_ioda_pe >> *pnv_ioda_setup_dev_PE(struct pci_dev *dev) >> return NULL; >> } >> - /* NOTE: We get only one ref to the pci_dev for the pdn, not for the >> - * pointer in the PE data structure, both should be destroyed at the >> - * same time. However, this needs to be looked at more closely again >> - * once we actually start removing things (Hotplug, SR-IOV, ...) >> - * >> - * At some point we want to remove the PDN completely anyways >> - */ >> - pci_dev_get(dev); >> pdn->pe_number = pe->pe_number; >> pe->flags = PNV_IODA_PE_DEV; >> pe->pdev = dev; >> @@ -1084,7 +1076,6 @@ static struct pnv_ioda_pe >> *pnv_ioda_setup_dev_PE(struct pci_dev *dev) >> pnv_ioda_free_pe(pe); >> pdn->pe_number = IODA_INVALID_PE; >> pe->pdev = NULL; >> - pci_dev_put(dev); >> return NULL; >> } >> @@ -1228,7 +1219,7 @@ static struct pnv_ioda_pe >> *pnv_ioda_setup_npu_PE(struct pci_dev *npu_pdev) >> */ >> dev_info(&npu_pdev->dev, >> "Associating to existing PE %x\n", pe_num); >> - pci_dev_get(npu_pdev); >> + pci_dev_get(npu_pdev); // still needed after 902bdc57451c ? > > Did you mean to leave that comment in? Yes, I assumed the series wouldn't get in on the first try and a nvlink-minded developer would weigh in :) Fred >> npu_pdn = pci_get_pdn(npu_pdev); >> rid = npu_pdev->bus->number << 8 | npu_pdn->devfn; >> npu_pdn->pe_number = pe_num; >> >