From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D5DC0651F for ; Thu, 4 Jul 2019 15:28:38 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDAC021721 for ; Thu, 4 Jul 2019 15:28:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDAC021721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45fhhM3tSzzDqdD for ; Fri, 5 Jul 2019 01:28:35 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=anshuman.khandual@arm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 45fhdp2xBLzDqZC for ; Fri, 5 Jul 2019 01:26:19 +1000 (AEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8316F2B; Thu, 4 Jul 2019 08:26:17 -0700 (PDT) Received: from [10.162.40.119] (p8cg001049571a15.blr.arm.com [10.162.40.119]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3B3A43F703; Thu, 4 Jul 2019 08:26:13 -0700 (PDT) Subject: Re: [PATCH V2] mm/ioremap: Probe platform for p4d huge map support To: Andrew Morton References: <1561699231-20991-1-git-send-email-anshuman.khandual@arm.com> <20190702160630.25de5558e9fe2d7d845f3472@linux-foundation.org> From: Anshuman Khandual Message-ID: Date: Thu, 4 Jul 2019 20:56:40 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190702160630.25de5558e9fe2d7d845f3472@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , x86@kernel.org, Peter Zijlstra , Catalin Marinas , Dave Hansen , Will Deacon , Michal Hocko , linux-mm@kvack.org, Ingo Molnar , linux-arm-kernel@lists.infradead.org, Andy Lutomirski , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, "Kirill A . Shutemov" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 07/03/2019 04:36 AM, Andrew Morton wrote: > On Fri, 28 Jun 2019 10:50:31 +0530 Anshuman Khandual wrote: > >> Finishing up what the commit c2febafc67734a ("mm: convert generic code to >> 5-level paging") started out while levelling up P4D huge mapping support >> at par with PUD and PMD. A new arch call back arch_ioremap_p4d_supported() >> is being added which just maintains status quo (P4D huge map not supported) >> on x86, arm64 and powerpc. > > Does this have any runtime effects? If so, what are they and why? If > not, what's the actual point? It just finishes up what the previous commit c2febafc67734a ("mm: convert generic code to 5-level paging") left off with respect p4d based huge page enablement for ioremap. When HAVE_ARCH_HUGE_VMAP is enabled its just a simple check from the arch about the support, hence runtime effects are minimal.