From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: Athira Rajeev <atrajeev@linux.vnet.ibm.com>, mpe@ellerman.id.au
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
mikey@neuling.org, maddy@linux.vnet.ibm.com, kjain@linux.ibm.com,
acme@kernel.org, jolsa@kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V4 0/4] powerpc/perf: Add support for perf extended regs in powerpc
Date: Mon, 27 Jul 2020 12:33:40 +0530 [thread overview]
Message-ID: <ff9affcd-aea1-b77c-0d96-245bdb774adb@linux.ibm.com> (raw)
In-Reply-To: <1595774713-1482-1-git-send-email-atrajeev@linux.vnet.ibm.com>
On 7/26/20 8:15 PM, Athira Rajeev wrote:
> Patch set to add support for perf extended register capability in
> powerpc. The capability flag PERF_PMU_CAP_EXTENDED_REGS, is used to
> indicate the PMU which support extended registers. The generic code
> define the mask of extended registers as 0 for non supported architectures.
>
> Patches 1 and 2 are the kernel side changes needed to include
> base support for extended regs in powerpc and in power10.
> Patches 3 and 4 are the perf tools side changes needed to support the
> extended registers.
>
> patch 1/4 defines the PERF_PMU_CAP_EXTENDED_REGS mask to output the
> values of mmcr0,mmcr1,mmcr2 for POWER9. Defines `PERF_REG_EXTENDED_MASK`
> at runtime which contains mask value of the supported registers under
> extended regs.
>
> patch 2/4 adds the extended regs support for power10 and exposes
> MMCR3, SIER2, SIER3 registers as part of extended regs.
>
> Patch 3/4 and 4/4 adds extended regs to sample_reg_mask in the tool
> side to use with `-I?` option for power9 and power10 respectively.
>
> Ravi bangoria found an issue with `perf record -I` while testing the
> changes. The same issue is currently being worked on here:
> https://lkml.org/lkml/2020/7/19/413 and will be resolved once fix
> from Jin Yao is merged.
>
> This patch series is based on powerpc/next
Apart from the issue with patch #1, the series LGTM..
Reviewed-and-Tested-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
prev parent reply other threads:[~2020-07-27 7:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 14:45 [PATCH V4 0/4] powerpc/perf: Add support for perf extended regs in powerpc Athira Rajeev
2020-07-26 14:45 ` [PATCH V4 1/4] powerpc/perf: Add support for outputting extended regs in perf intr_regs Athira Rajeev
2020-07-27 7:01 ` Ravi Bangoria
2020-07-26 14:45 ` [PATCH V4 2/4] powerpc/perf: Add extended regs support for power10 platform Athira Rajeev
2020-07-26 14:45 ` [PATCH V4 3/4] tools/perf: Add perf tools support for extended register capability in powerpc Athira Rajeev
2020-07-26 14:45 ` [PATCH V4 4/4] tools/perf: Add perf tools support for extended regs in power10 Athira Rajeev
2020-07-27 7:03 ` Ravi Bangoria [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff9affcd-aea1-b77c-0d96-245bdb774adb@linux.ibm.com \
--to=ravi.bangoria@linux.ibm.com \
--cc=acme@kernel.org \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).