From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ywKm=U3=lists.ozlabs.org=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-11.7 required=3.0
	tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,
	MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 5F5F5C4321A
	for <linuxppc-dev@archiver.kernel.org>; Fri, 28 Jun 2019 09:20:04 +0000 (UTC)
Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id E0370208CB
	for <linuxppc-dev@archiver.kernel.org>; Fri, 28 Jun 2019 09:20:03 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0370208CB
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org
Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])
	by lists.ozlabs.org (Postfix) with ESMTP id 45Zrns4cG8zDqlc
	for <linuxppc-dev@archiver.kernel.org>; Fri, 28 Jun 2019 19:20:01 +1000 (AEST)
Authentication-Results: lists.ozlabs.org;
 spf=pass (mailfrom) smtp.mailfrom=suse.de
 (client-ip=195.135.220.15; helo=mx1.suse.de; envelope-from=tiwai@suse.de;
 receiver=<UNKNOWN>)
Authentication-Results: lists.ozlabs.org;
 dmarc=none (p=none dis=none) header.from=suse.de
Received: from mx1.suse.de (mx2.suse.de [195.135.220.15])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.ozlabs.org (Postfix) with ESMTPS id 45ZrlG2KHvzDqB2
 for <linuxppc-dev@lists.ozlabs.org>; Fri, 28 Jun 2019 19:17:46 +1000 (AEST)
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.220.254])
 by mx1.suse.de (Postfix) with ESMTP id 1A04FAFC9;
 Fri, 28 Jun 2019 09:17:43 +0000 (UTC)
Date: Fri, 28 Jun 2019 11:17:42 +0200
Message-ID: <s5hftnu6pc9.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Fuqian Huang <huangfq.daxian@gmail.com>
Subject: Re: [alsa-devel] [PATCH v2 27/27] sound: ppc: remove unneeded	memset
 after dma_alloc_coherent
In-Reply-To: <CABXRUiT6jSP2xL9JyqngS9KBx_=fZ13x0UGGFPnQPrfh-_N5xQ@mail.gmail.com>
References: <20190628025055.16242-1-huangfq.daxian@gmail.com>
 <83108dee-72f7-e56f-95f6-26162c9a0ccc@c-s.fr>
 <CABXRUiT6jSP2xL9JyqngS9KBx_=fZ13x0UGGFPnQPrfh-_N5xQ@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: linuxppc-dev@lists.ozlabs.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev/>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>
Cc: Rob Herring <robh@kernel.org>, alsa-devel@alsa-project.org,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org,
 Richard Fontana <rfontana@redhat.com>, Paul Mackerras <paulus@samba.org>,
 Thomas Gleixner <tglx@linutronix.de>, linuxppc-dev@lists.ozlabs.org,
 Allison Randal <allison@lohutok.net>
Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org
Sender: "Linuxppc-dev"
 <linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org>

On Fri, 28 Jun 2019 11:11:08 +0200,
Fuqian Huang wrote:
> 
> The merge commit log tells (dma-mapping: zero memory returned from
> dma_alloc_* and deprecating the dma_zalloc_coherent).
> I used this commit just want to say that dma_alloc_coherent  has
> zeroed the allocated memory.
> Sorry for this mistake.
> 
> Maybe this commit 518a2f1925c3("dma-mapping: zero memory returned from
> dma_alloc_*") is correct.

Are you going to resubmit v3 patchset?  If the correction is specific
to this patch, I can correct the description in my side, too...


thanks,

Takashi

> 
> Christophe Leroy <christophe.leroy@c-s.fr> 於 2019年6月28日週五 下午4:59寫道：
> 
> >
> >
> >
> > Le 28/06/2019 à 04:50, Fuqian Huang a écrit :
> > > In commit af7ddd8a627c
> > > ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> > > dma_alloc_coherent has already zeroed the memory.
> > > So memset is not needed.
> >
> > You are refering to a merge commit, is that correct ?
> >
> > I can't see anything related in that commit, can you please pinpoint it ?
> >
> > As far as I can see, on powerpc the memory has always been zeroized
> > (since 2005 at least).
> >
> > Christophe
> >
> > >
> > > Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> > > ---
> > >   sound/ppc/pmac.c | 1 -
> > >   1 file changed, 1 deletion(-)
> > >
> > > diff --git a/sound/ppc/pmac.c b/sound/ppc/pmac.c
> > > index 1b11e53f6a62..1ab12f4f8631 100644
> > > --- a/sound/ppc/pmac.c
> > > +++ b/sound/ppc/pmac.c
> > > @@ -56,7 +56,6 @@ static int snd_pmac_dbdma_alloc(struct snd_pmac *chip, struct pmac_dbdma *rec, i
> > >       if (rec->space == NULL)
> > >               return -ENOMEM;
> > >       rec->size = size;
> > > -     memset(rec->space, 0, rsize);
> > >       rec->cmds = (void __iomem *)DBDMA_ALIGN(rec->space);
> > >       rec->addr = rec->dma_base + (unsigned long)((char *)rec->cmds - (char *)rec->space);
> > >
> > >
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel