Live-Patching Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] x86/stacktrace: update kconfig help text for reliable unwinders
@ 2019-11-07  3:29 Joe Lawrence
  2019-11-07  3:34 ` Josh Poimboeuf
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Joe Lawrence @ 2019-11-07  3:29 UTC (permalink / raw)
  To: linux-kernel, live-patching; +Cc: Josh Poimboeuf

commit 6415b38bae26 ("x86/stacktrace: Enable HAVE_RELIABLE_STACKTRACE
for the ORC unwinder") added the ORC unwinder as a "reliable" unwinder.
Update the help text to reflect that change: the frame pointer unwinder
is no longer the only one that can provide HAVE_RELIABLE_STACKTRACE.

Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
---

v2: dropped hunk that added unnecessary text to UNWIND_GUESS

 arch/x86/Kconfig.debug | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index bf9cd83de777..409c00f74e60 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -316,10 +316,6 @@ config UNWINDER_FRAME_POINTER
 	  unwinder, but the kernel text size will grow by ~3% and the kernel's
 	  overall performance will degrade by roughly 5-10%.
 
-	  This option is recommended if you want to use the livepatch
-	  consistency model, as this is currently the only way to get a
-	  reliable stack trace (CONFIG_HAVE_RELIABLE_STACKTRACE).
-
 config UNWINDER_GUESS
 	bool "Guess unwinder"
 	depends on EXPERT
-- 
2.21.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] x86/stacktrace: update kconfig help text for reliable unwinders
  2019-11-07  3:29 [PATCH v2] x86/stacktrace: update kconfig help text for reliable unwinders Joe Lawrence
@ 2019-11-07  3:34 ` Josh Poimboeuf
  2019-11-07 14:54   ` Petr Mladek
  2019-11-07  8:44 ` Miroslav Benes
  2019-11-07 12:23 ` Kamalesh Babulal
  2 siblings, 1 reply; 5+ messages in thread
From: Josh Poimboeuf @ 2019-11-07  3:34 UTC (permalink / raw)
  To: Joe Lawrence; +Cc: linux-kernel, live-patching

On Wed, Nov 06, 2019 at 10:29:58PM -0500, Joe Lawrence wrote:
> commit 6415b38bae26 ("x86/stacktrace: Enable HAVE_RELIABLE_STACKTRACE
> for the ORC unwinder") added the ORC unwinder as a "reliable" unwinder.
> Update the help text to reflect that change: the frame pointer unwinder
> is no longer the only one that can provide HAVE_RELIABLE_STACKTRACE.
> 
> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> ---
> 
> v2: dropped hunk that added unnecessary text to UNWIND_GUESS
> 
>  arch/x86/Kconfig.debug | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
> index bf9cd83de777..409c00f74e60 100644
> --- a/arch/x86/Kconfig.debug
> +++ b/arch/x86/Kconfig.debug
> @@ -316,10 +316,6 @@ config UNWINDER_FRAME_POINTER
>  	  unwinder, but the kernel text size will grow by ~3% and the kernel's
>  	  overall performance will degrade by roughly 5-10%.
>  
> -	  This option is recommended if you want to use the livepatch
> -	  consistency model, as this is currently the only way to get a
> -	  reliable stack trace (CONFIG_HAVE_RELIABLE_STACKTRACE).
> -
>  config UNWINDER_GUESS
>  	bool "Guess unwinder"
>  	depends on EXPERT
> -- 
> 2.21.0
> 

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

-- 
Josh


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] x86/stacktrace: update kconfig help text for reliable unwinders
  2019-11-07  3:29 [PATCH v2] x86/stacktrace: update kconfig help text for reliable unwinders Joe Lawrence
  2019-11-07  3:34 ` Josh Poimboeuf
@ 2019-11-07  8:44 ` Miroslav Benes
  2019-11-07 12:23 ` Kamalesh Babulal
  2 siblings, 0 replies; 5+ messages in thread
From: Miroslav Benes @ 2019-11-07  8:44 UTC (permalink / raw)
  To: Joe Lawrence; +Cc: linux-kernel, live-patching, Josh Poimboeuf

On Wed, 6 Nov 2019, Joe Lawrence wrote:

> commit 6415b38bae26 ("x86/stacktrace: Enable HAVE_RELIABLE_STACKTRACE
> for the ORC unwinder") added the ORC unwinder as a "reliable" unwinder.
> Update the help text to reflect that change: the frame pointer unwinder
> is no longer the only one that can provide HAVE_RELIABLE_STACKTRACE.
> 
> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>

Acked-by: Miroslav Benes <mbenes@suse.cz>

M

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] x86/stacktrace: update kconfig help text for reliable unwinders
  2019-11-07  3:29 [PATCH v2] x86/stacktrace: update kconfig help text for reliable unwinders Joe Lawrence
  2019-11-07  3:34 ` Josh Poimboeuf
  2019-11-07  8:44 ` Miroslav Benes
@ 2019-11-07 12:23 ` Kamalesh Babulal
  2 siblings, 0 replies; 5+ messages in thread
From: Kamalesh Babulal @ 2019-11-07 12:23 UTC (permalink / raw)
  To: Joe Lawrence, linux-kernel, live-patching; +Cc: Josh Poimboeuf

On 11/7/19 8:59 AM, Joe Lawrence wrote:
> commit 6415b38bae26 ("x86/stacktrace: Enable HAVE_RELIABLE_STACKTRACE
> for the ORC unwinder") added the ORC unwinder as a "reliable" unwinder.
> Update the help text to reflect that change: the frame pointer unwinder
> is no longer the only one that can provide HAVE_RELIABLE_STACKTRACE.
> 
> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>

Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>

-- 
Kamalesh


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] x86/stacktrace: update kconfig help text for reliable unwinders
  2019-11-07  3:34 ` Josh Poimboeuf
@ 2019-11-07 14:54   ` Petr Mladek
  0 siblings, 0 replies; 5+ messages in thread
From: Petr Mladek @ 2019-11-07 14:54 UTC (permalink / raw)
  To: Josh Poimboeuf; +Cc: Joe Lawrence, linux-kernel, live-patching

On Wed 2019-11-06 21:34:58, Josh Poimboeuf wrote:
> On Wed, Nov 06, 2019 at 10:29:58PM -0500, Joe Lawrence wrote:
> > commit 6415b38bae26 ("x86/stacktrace: Enable HAVE_RELIABLE_STACKTRACE
> > for the ORC unwinder") added the ORC unwinder as a "reliable" unwinder.
> > Update the help text to reflect that change: the frame pointer unwinder
> > is no longer the only one that can provide HAVE_RELIABLE_STACKTRACE.
> > 
> > Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> 
> Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

It is committed in livepatch.git, branch for-5.5/core.

Best Regards,
Petr

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07  3:29 [PATCH v2] x86/stacktrace: update kconfig help text for reliable unwinders Joe Lawrence
2019-11-07  3:34 ` Josh Poimboeuf
2019-11-07 14:54   ` Petr Mladek
2019-11-07  8:44 ` Miroslav Benes
2019-11-07 12:23 ` Kamalesh Babulal

Live-Patching Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/live-patching/0 live-patching/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 live-patching live-patching/ https://lore.kernel.org/live-patching \
		live-patching@vger.kernel.org
	public-inbox-index live-patching

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.live-patching


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git