From: "Madhavan T. Venkataraman" <email@example.com> To: Mark Brown <firstname.lastname@example.org> Cc: email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [RFC PATCH v3 3/4] arm64: Handle miscellaneous functions in .text and .init.text Date: Thu, 6 May 2021 10:57:09 -0500 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20210506153756.GA3377@sirena.org.uk> On 5/6/21 10:37 AM, Mark Brown wrote: > On Thu, May 06, 2021 at 10:30:21AM -0500, Madhavan T. Venkataraman wrote: >> On 5/6/21 9:12 AM, Mark Brown wrote: >>> On Mon, May 03, 2021 at 12:36:14PM -0500, firstname.lastname@example.org wrote: > >>> I was thinking it'd be good to do this by modifying SYM_CODE_START() to >>> emit the section, that way nobody can forget to put any SYM_CODE into a >>> special section. That does mean we'd have to first introduce a new > >> OK. I could make the section an argument to SYM_CODE*() so that a developer >> will never miss that. Some documentation may be in order so the guidelines >> are clear. I will do the doc patch separately, if that is alright with >> you all. > > I was thinking to have standard SYM_CODE default to a section then a > variant for anything that cares (like how we have SYM_FUNC_PI and > friends for the PI code for EFI). > OK. >>> We also have a bunch of things like __cpu_soft_restart which don't seem >>> to be called out here but need to be in .idmap.text. > >> It is already in .idmap.text. > > Right, I meant that I was expecting to see things that need to be in a > specific section other than .code.text called out separately here if > we're enumerating them. Though if the annotations are done separately > then this patch wouldn't need to do that calling out at all, it'd be > covered as part of fiddling around with the annotations. > OK. Madhavan
next prev parent reply other threads:[~2021-05-06 15:57 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <65cf4dfbc439b010b50a0c46ec500432acde86d6> 2021-05-03 17:36 ` [RFC PATCH v3 0/4] arm64: Stack trace reliability checks in the unwinder madvenka 2021-05-03 17:36 ` [RFC PATCH v3 1/4] arm64: Introduce stack " madvenka 2021-05-04 15:50 ` Mark Brown 2021-05-04 19:14 ` Madhavan T. Venkataraman 2021-05-04 21:52 ` Josh Poimboeuf 2021-05-04 23:13 ` Madhavan T. Venkataraman 2021-05-05 0:07 ` Josh Poimboeuf 2021-05-05 0:21 ` Madhavan T. Venkataraman 2021-05-03 17:36 ` [RFC PATCH v3 2/4] arm64: Check the return PC against unreliable code sections madvenka 2021-05-04 16:05 ` Mark Brown 2021-05-04 19:03 ` Madhavan T. Venkataraman 2021-05-04 19:32 ` Madhavan T. Venkataraman 2021-05-05 16:46 ` Mark Brown 2021-05-05 18:48 ` Madhavan T. Venkataraman 2021-05-05 18:50 ` Madhavan T. Venkataraman 2021-05-06 13:45 ` Mark Brown 2021-05-06 15:21 ` Madhavan T. Venkataraman 2021-05-05 16:34 ` Mark Brown 2021-05-05 17:51 ` Madhavan T. Venkataraman 2021-05-05 19:30 ` Ard Biesheuvel 2021-05-05 20:00 ` Madhavan T. Venkataraman 2021-05-03 17:36 ` [RFC PATCH v3 3/4] arm64: Handle miscellaneous functions in .text and .init.text madvenka 2021-05-06 14:12 ` Mark Brown 2021-05-06 15:30 ` Madhavan T. Venkataraman 2021-05-06 15:32 ` Madhavan T. Venkataraman 2021-05-06 15:44 ` Mark Brown 2021-05-06 15:56 ` Madhavan T. Venkataraman 2021-05-06 15:37 ` Mark Brown 2021-05-06 15:57 ` Madhavan T. Venkataraman [this message] 2021-05-03 17:36 ` [RFC PATCH v3 4/4] arm64: Handle funtion graph tracer better in the unwinder madvenka 2021-05-06 14:43 ` Mark Brown 2021-05-06 15:20 ` Madhavan T. Venkataraman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [RFC PATCH v3 3/4] arm64: Handle miscellaneous functions in .text and .init.text' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).