From: Joe Lawrence <joe.lawrence@redhat.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Miroslav Benes <mbenes@suse.cz>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
Nicolai Stange <nstange@suse.de>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 0/5] livepatch: new API to track system state changes
Date: Fri, 21 Jun 2019 09:19:32 -0400 [thread overview]
Message-ID: <20190621131932.GA20356@redhat.com> (raw)
In-Reply-To: <20190611135627.15556-1-pmladek@suse.com>
On Tue, Jun 11, 2019 at 03:56:22PM +0200, Petr Mladek wrote:
> Hi,
>
> this is another piece in the puzzle that helps to maintain more
> livepatches.
>
> Especially pre/post (un)patch callbacks might change a system state.
> Any newly installed livepatch has to somehow deal with system state
> modifications done be already installed livepatches.
>
> This patchset provides, hopefully, a simple and generic API that
> helps to keep and pass information between the livepatches.
> It is also usable to prevent loading incompatible livepatches.
>
Thanks for posting, Petr and aplogies for not getting to this RFC
earlier. I think this strikes a reasonable balance between the (too)
"simplified" versioning scheme that I posted a few weeks back, and what
I was afraid might have been too complicated callback-state-version
concept.
This RFC reads fairly straightforward and especially easy to review
given the included documentation and self-tests. I'll add a few
comments per patch, but again, I like how this came out.
> There was also a related idea to add a sticky flag. It should be
> easy to add it later. It would perfectly fit into the new struct
> klp_state.
I think so, too. It would indicate that the patch is introducing a
state which cannot be safely unloaded. But we can talk about that at a
later time if/when we want to add that wrinkle to klp_state.
-- Joe
next parent reply other threads:[~2019-06-21 13:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190611135627.15556-1-pmladek@suse.com>
2019-06-21 13:19 ` Joe Lawrence [this message]
[not found] ` <20190611135627.15556-3-pmladek@suse.com>
2019-06-21 13:43 ` [RFC 2/5] livepatch: Basic API to track system state changes Joe Lawrence
2019-06-24 9:32 ` Nicolai Stange
[not found] ` <20190611135627.15556-5-pmladek@suse.com>
2019-06-21 14:15 ` [RFC 4/5] livepatch: Documentation of the new API for tracking " Joe Lawrence
[not found] ` <20190611135627.15556-6-pmladek@suse.com>
2019-06-21 11:54 ` [RFC 5/5] livepatch: Selftests of the " Miroslav Benes
2019-06-21 14:19 ` Joe Lawrence
2019-06-24 9:27 ` [RFC 0/5] livepatch: new API to track " Nicolai Stange
[not found] ` <20190611135627.15556-4-pmladek@suse.com>
2019-06-21 11:27 ` [RFC 3/5] livepatch: Allow to distinguish different version of " Miroslav Benes
2019-06-21 14:09 ` Joe Lawrence
2019-06-21 15:00 ` Joe Lawrence
2019-06-24 10:26 ` Nicolai Stange
2019-07-18 11:38 ` Petr Mladek
2019-07-18 9:08 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621131932.GA20356@redhat.com \
--to=joe.lawrence@redhat.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=nstange@suse.de \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).