From: Petr Mladek <pmladek@suse.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Johannes Erdfelt <johannes@erdfelt.com>,
Steven Rostedt <rostedt@goodmis.org>,
Jessica Yu <jeyu@kernel.org>, Jiri Kosina <jikos@kernel.org>,
mhiramat@kernel.org, Ingo Molnar <mingo@kernel.org>,
tglx@linutronix.de, torvalds@linux-foundation.org,
Joe Lawrence <joe.lawrence@redhat.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
linux-kernel@vger.kernel.org, live-patching@vger.kernel.org
Subject: Re: [PATCH] ftrace: Remove possible deadlock between register_kprobe() and ftrace_run_update_code()
Date: Fri, 28 Jun 2019 12:52:32 +0200 [thread overview]
Message-ID: <20190628105232.6arwis5u33li6twr@pathway.suse.cz> (raw)
In-Reply-To: <alpine.LSU.2.21.1906280928410.17146@pobox.suse.cz>
On Fri 2019-06-28 09:32:03, Miroslav Benes wrote:
> On Thu, 27 Jun 2019, Petr Mladek wrote:
> > @@ -2611,12 +2610,10 @@ static void ftrace_run_update_code(int command)
> > {
> > int ret;
> >
> > - mutex_lock(&text_mutex);
> > -
> > ret = ftrace_arch_code_modify_prepare();
> > FTRACE_WARN_ON(ret);
> > if (ret)
> > - goto out_unlock;
> > + return ret;
>
> Should be just "return;", because the function is "static void".
Grr, I usually check compiler warnings but I evidently skipped it
in this case :-(
Steven, should I send a fixed/folloup patch or will you just
fix it when pushing?
Best Regards,
Petr
next prev parent reply other threads:[~2019-06-28 10:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 8:13 [PATCH] ftrace: Remove possible deadlock between register_kprobe() and ftrace_run_update_code() Petr Mladek
2019-06-27 22:17 ` Thomas Gleixner
2019-06-27 22:47 ` Josh Poimboeuf
2019-06-27 23:04 ` Steven Rostedt
2019-06-27 23:09 ` Thomas Gleixner
2019-06-27 23:12 ` Steven Rostedt
2019-06-27 23:19 ` Josh Poimboeuf
2019-06-27 23:25 ` Thomas Gleixner
2019-06-27 23:25 ` Steven Rostedt
2019-06-28 1:13 ` Steven Rostedt
2019-06-28 1:17 ` Josh Poimboeuf
2019-06-28 17:33 ` Jiri Kosina
2019-06-28 17:37 ` Steven Rostedt
2019-06-29 20:56 ` Jiri Kosina
2019-06-29 21:19 ` Steven Rostedt
2019-06-29 21:22 ` [PATCH] ftrace/x86: anotate text_mutex split between ftrace_arch_code_modify_post_process() and ftrace_arch_code_modify_prepare() Jiri Kosina
2019-06-28 7:32 ` [PATCH] ftrace: Remove possible deadlock between register_kprobe() and ftrace_run_update_code() Miroslav Benes
2019-06-28 10:52 ` Petr Mladek [this message]
2019-06-28 13:54 ` Steven Rostedt
2019-06-28 15:46 ` Steven Rostedt
2019-06-28 15:51 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628105232.6arwis5u33li6twr@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=jeyu@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=johannes@erdfelt.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).