live-patching.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Lawrence <joe.lawrence@redhat.com>
To: shuah@kernel.org
Cc: live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [RFC PATCH] selftests/livepatch: only consider supported arches
Date: Fri, 12 Jul 2019 13:25:17 -0400	[thread overview]
Message-ID: <20190712172517.GA15872@redhat.com> (raw)
In-Reply-To: <20190712171402.15930-1-joe.lawrence@redhat.com>

On Fri, Jul 12, 2019 at 01:14:02PM -0400, Joe Lawrence wrote:
> Only run the livepatching self-tests on x86_64 and ppc64le arches.
> 
> Reported-by: Jiri Benc <jbenc@redhat.com>
> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> ---
>  tools/testing/selftests/livepatch/Makefile | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tools/testing/selftests/livepatch/Makefile b/tools/testing/selftests/livepatch/Makefile
> index fd405402c3ff..9842fb473d42 100644
> --- a/tools/testing/selftests/livepatch/Makefile
> +++ b/tools/testing/selftests/livepatch/Makefile
> @@ -1,5 +1,16 @@
>  # SPDX-License-Identifier: GPL-2.0
>  
> +ARCH ?= $(shell uname -m 2>/dev/null || echo not)
> +
> +ifeq ($(ARCH),x86_64)
> +livepatch_supported := 1
> +endif
> +ifeq ($(ARCH),ppc64le)
> +livepatch_supported := 1
> +endif
> +
> +ifdef livepatch_supported
> +
>  TEST_PROGS_EXTENDED := functions.sh
>  TEST_PROGS := \
>  	test-livepatch.sh \
> @@ -7,3 +18,5 @@ TEST_PROGS := \
>  	test-shadow-vars.sh
>  
>  include ../lib.mk
> +
> +endif
> -- 
> 2.21.0
> 

Hi Shuah,

This was change was a quick and dirty fix to avoid inadvertent errors
reported by run_kselftest.sh on arches unsupported by livepatch.

Ideally we would check CONFIG_TEST_LIVEPATCH instead of the arches
directly:  This would allow distros to "turn off" this particular set of
selftests through the kernel configuration.  Also, setting 
CONFIG_TEST_LIVEPATCH=m determines whether supporting livepatch
self-test modules (in lib/livepatch) will be built.  Without it, these
self-test scripts are useless.

However, I didn't see that $(CONFIG_TEST_LIVEPATCH) was set when
invoking tools/testing/selftests/livepatch/Makefile.  I don't know how
tools/testing/selftests/vDSO/Makefile is using $(CONFIG_X86_32) but
perhaps that isn't working either.

Any suggestions?  Should we modify the test scripts themselves to deal
with a !CONFIG_TEST_LIVEPATCH environment?

Thanks,

-- Joe

  reply	other threads:[~2019-07-12 17:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12 17:14 [RFC PATCH] selftests/livepatch: only consider supported arches Joe Lawrence
2019-07-12 17:25 ` Joe Lawrence [this message]
2019-07-12 17:43   ` shuah
2019-07-12 17:58     ` Joe Lawrence
2019-07-12 18:14       ` shuah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190712172517.GA15872@redhat.com \
    --to=joe.lawrence@redhat.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).