From: Jiri Benc <jbenc@redhat.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Joe Lawrence <joe.lawrence@redhat.com>,
linux-kselftest@vger.kernel.org, live-patching@vger.kernel.org,
shuah@kernel.org
Subject: Re: [PATCH v2] selftests/livepatch: add test skip handling
Date: Wed, 17 Jul 2019 14:45:24 +0200 [thread overview]
Message-ID: <20190717144524.715f46c4@redhat.com> (raw)
In-Reply-To: <20190717120055.pno2b7zczpcgaixg@pathway.suse.cz>
On Wed, 17 Jul 2019 14:00:55 +0200, Petr Mladek wrote:
> Adding Jiri into CC to be sure that we really solved the original problem.
The patch looks good to me, the runner expects 4 as an indication that
the test was skipped.
> I get the following output when livepatching is not configured:
>
> $> make run_tests
> TAP version 13
> 1..4
> # selftests: livepatch: test-livepatch.sh
> # TEST: basic function patching ... SKIP: Failed modprobe --dry-run of module: test_klp_livepatch
> not ok 1 selftests: livepatch: test-livepatch.sh # SKIP
> # selftests: livepatch: test-callbacks.sh
> # TEST: target module before livepatch ... SKIP: Failed modprobe --dry-run of module: test_klp_callbacks_mod
> not ok 2 selftests: livepatch: test-callbacks.sh # SKIP
> # selftests: livepatch: test-shadow-vars.sh
> # TEST: basic shadow variable API ... SKIP: Failed modprobe --dry-run of module: test_klp_shadow_vars
> not ok 3 selftests: livepatch: test-shadow-vars.sh # SKIP
> # selftests: livepatch: test-state.sh
> # TEST: system state modification ... SKIP: Failed modprobe --dry-run of module: test_klp_state
> not ok 4 selftests: livepatch: test-state.sh # SKIP
>
> Jiri, is it acceptable solution for you, please?
It looks correct. My reading of the TAP 13 specification is that it
should be returned as "ok" instead of "not ok" but that is not a
problem of this patch.
> Otherwise, the patch looks fine to me. If Jiri is fine
> then feel free to use:
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
Sure.
Acked-by: Jiri Benc <jbenc@redhat.com>
Thanks!
Jiri
next prev parent reply other threads:[~2019-07-17 12:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 13:34 [PATCH v2] selftests/livepatch: add test skip handling Joe Lawrence
2019-07-17 9:12 ` Miroslav Benes
2019-07-17 12:00 ` Petr Mladek
2019-07-17 12:45 ` Jiri Benc [this message]
2019-07-17 14:45 ` Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717144524.715f46c4@redhat.com \
--to=jbenc@redhat.com \
--cc=joe.lawrence@redhat.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).