From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0DB0C7618B for ; Wed, 24 Jul 2019 06:27:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B3557229F3 for ; Wed, 24 Jul 2019 06:27:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726086AbfGXG1c (ORCPT ); Wed, 24 Jul 2019 02:27:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:39784 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725882AbfGXG1c (ORCPT ); Wed, 24 Jul 2019 02:27:32 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D3F77AC94; Wed, 24 Jul 2019 06:27:30 +0000 (UTC) Date: Wed, 24 Jul 2019 08:27:30 +0200 From: Petr Mladek To: Joe Lawrence Cc: linux-kselftest@vger.kernel.org, live-patching@vger.kernel.org, shuah@kernel.org, Jiri Benc Subject: Re: [PATCH v3] selftests/livepatch: add test skip handling Message-ID: <20190724062730.xtutfqgpsr3pubv7@pathway.suse.cz> References: <20190722140544.29867-1-joe.lawrence@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190722140544.29867-1-joe.lawrence@redhat.com> User-Agent: NeoMutt/20170912 (1.9.0) Sender: live-patching-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org On Mon 2019-07-22 10:05:44, Joe Lawrence wrote: > Add a skip() message function that stops the test, logs an explanation, > and sets the "skip" return code (4). > > Before loading a livepatch self-test kernel module, first verify that > we've built and installed it by running a 'modprobe --dry-run'. This > should catch a few environment issues, including !CONFIG_LIVEPATCH and > !CONFIG_TEST_LIVEPATCH. In these cases, exit gracefully with the new > skip() function. > > Reported-by: Jiri Benc > Suggested-by: Shuah Khan > Signed-off-by: Joe Lawrence Reviewed-by: Petr Mladek Best Regards, Petr PS: No need to send v4. The missing "to", suggested by Shuah, could get added when pushing the patch into the repo.