From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A78CC352AA for ; Wed, 2 Oct 2019 13:35:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3AF7921783 for ; Wed, 2 Oct 2019 13:35:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727487AbfJBNfz (ORCPT ); Wed, 2 Oct 2019 09:35:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:48560 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726948AbfJBNfx (ORCPT ); Wed, 2 Oct 2019 09:35:53 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E025CB143; Wed, 2 Oct 2019 13:35:51 +0000 (UTC) Date: Wed, 2 Oct 2019 15:35:51 +0200 From: Petr Mladek To: Miroslav Benes Cc: jikos@kernel.org, jpoimboe@redhat.com, joe.lawrence@redhat.com, nstange@suse.de, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 2/3] livepatch: Unify functions for writing and clearing object relocations Message-ID: <20191002133551.4sqeyisjq252kf7o@pathway.suse.cz> References: <20190905124514.8944-1-mbenes@suse.cz> <20190905124514.8944-3-mbenes@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190905124514.8944-3-mbenes@suse.cz> User-Agent: NeoMutt/20170912 (1.9.0) Sender: live-patching-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org On Thu 2019-09-05 14:45:13, Miroslav Benes wrote: > Functions klp_write_object_relocations() and > klp_clear_object_relocations() share a lot of code. Take the code out to > a common function and provide the specific actions through callbacks. > > Signed-off-by: Miroslav Benes I would prefer when the callback is introduced before the 1st patch. I do not resist on it. This patch looks good, so: Reviewed-by: Petr Mladek Best Regards, Petr