live-patching.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Petr Mladek <pmladek@suse.com>,
	jikos@kernel.org, Joe Lawrence <joe.lawrence@redhat.com>,
	jpoimboe@redhat.com, mingo@redhat.com,
	linux-kernel@vger.kernel.org, live-patching@vger.kernel.org
Subject: Re: [PATCH 0/3] ftrace: Introduce PERMANENT ftrace_ops flag
Date: Thu, 10 Oct 2019 09:43:52 -0400	[thread overview]
Message-ID: <20191010094352.35056c84@gandalf.local.home> (raw)
In-Reply-To: <alpine.LSU.2.21.1910101535310.32665@pobox.suse.cz>

On Thu, 10 Oct 2019 15:38:20 +0200 (CEST)
Miroslav Benes <mbenes@suse.cz> wrote:

> On Thu, 10 Oct 2019, Steven Rostedt wrote:
> 
> > On Thu, 10 Oct 2019 10:50:35 +0200
> > Petr Mladek <pmladek@suse.com> wrote:
> >   
> > > It will make the flag unusable for other ftrace users. But it
> > > will be already be the case when it can't be disabled.  
> > 
> > Honestly, I hate that flag. Most people don't even know about it. It
> > was added in the beginning of ftrace as a way to stop function tracing
> > in the latency tracer. But that use case has been obsoleted by
> > 328df4759c03e ("tracing: Add function-trace option to disable function
> > tracing of latency tracers"). I may just remove the damn thing and only
> > add it back if somebody complains about it.  
> 
> That would of course solve the issue too and code removal is always 
> better.
>

Yes, but let's still add the patch that does the permanent check. And
then I'll put the "remove this flag" patch on top (and revert
everything else). This way, if somebody complains, and Linus reverts
the removal patch, we don't end up breaking live kernel patching
again ;-)

-- Steve

  reply	other threads:[~2019-10-10 13:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07  8:17 [PATCH 0/3] ftrace: Introduce PERMANENT ftrace_ops flag Miroslav Benes
2019-10-07  8:17 ` [PATCH 1/3] ftrace: Make test_rec_ops_needs_regs() generic Miroslav Benes
2019-10-07  8:17 ` [PATCH 2/3] ftrace: Introduce PERMANENT ftrace_ops flag Miroslav Benes
2019-10-07  8:17 ` [PATCH 3/3] livepatch: Use FTRACE_OPS_FL_PERMANENT Miroslav Benes
2019-10-08 19:35 ` [PATCH 0/3] ftrace: Introduce PERMANENT ftrace_ops flag Joe Lawrence
2019-10-08 19:50   ` Steven Rostedt
2019-10-09 10:33     ` Miroslav Benes
2019-10-09 11:22   ` Petr Mladek
2019-10-09 14:23     ` Joe Lawrence
2019-10-09 14:26     ` Steven Rostedt
2019-10-10  8:50       ` Petr Mladek
2019-10-10 13:14         ` Steven Rostedt
2019-10-10 13:38           ` Miroslav Benes
2019-10-10 13:43             ` Steven Rostedt [this message]
2019-10-10 13:44               ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191010094352.35056c84@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=mingo@redhat.com \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).