Live-Patching Archive on lore.kernel.org
 help / color / Atom feed
From: Joe Lawrence <joe.lawrence@redhat.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: jpoimboe@redhat.com, jikos@kernel.org, pmladek@suse.com,
	shuah@kernel.org, linux-kernel@vger.kernel.org,
	live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests/livepatch: Disable the timeout
Date: Fri, 25 Oct 2019 10:14:11 -0400
Message-ID: <20191025141411.GA17156@redhat.com> (raw)
In-Reply-To: <20191025115041.23186-1-mbenes@suse.cz>

On Fri, Oct 25, 2019 at 01:50:41PM +0200, Miroslav Benes wrote:
> Commit 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second
> timeout per test") introduced a timeout per test. Livepatch tests could
> run longer than 45 seconds, especially on slower machines. They do not
> hang and they detect if something goes awry with internal accounting.
> 
> Better than looking for an arbitrary value, just disable the timeout for
> livepatch selftests.
> 
> Signed-off-by: Miroslav Benes <mbenes@suse.cz>
> ---
>  tools/testing/selftests/livepatch/settings | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 tools/testing/selftests/livepatch/settings
> 
> diff --git a/tools/testing/selftests/livepatch/settings b/tools/testing/selftests/livepatch/settings
> new file mode 100644
> index 000000000000..e7b9417537fb
> --- /dev/null
> +++ b/tools/testing/selftests/livepatch/settings
> @@ -0,0 +1 @@
> +timeout=0
> -- 
> 2.23.0
> 

Yes, disabling the timeout for our tests makes sense since they already
have internal checking.  Tested this in a VM and looks good to me,
thanks.

Reviewed-by: Joe Lawrence <joe.lawrence@redhat.com>

-- Joe


  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 11:50 Miroslav Benes
2019-10-25 14:14 ` Joe Lawrence [this message]
2019-10-25 18:00 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191025141411.GA17156@redhat.com \
    --to=joe.lawrence@redhat.com \
    --cc=jikos@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Live-Patching Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/live-patching/0 live-patching/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 live-patching live-patching/ https://lore.kernel.org/live-patching \
		live-patching@vger.kernel.org
	public-inbox-index live-patching

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.live-patching


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git