Live-Patching Archive on lore.kernel.org
 help / color / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: linux-kernel@vger.kernel.org, live-patching@vger.kernel.org
Subject: Re: [PATCH] x86/stacktrace: update kconfig help text for reliable unwinders
Date: Wed, 6 Nov 2019 17:54:23 -0600
Message-ID: <20191106235423.hjamrggd4x3js5hm@treble> (raw)
In-Reply-To: <c8bae684-2a46-68e6-dc43-a8c215bdd111@redhat.com>

On Wed, Nov 06, 2019 at 06:16:28PM -0500, Joe Lawrence wrote:
> On 11/6/19 6:05 PM, Josh Poimboeuf wrote:
> > On Wed, Nov 06, 2019 at 05:43:44PM -0500, Joe Lawrence wrote:
> > > commit 6415b38bae26 ("x86/stacktrace: Enable HAVE_RELIABLE_STACKTRACE
> > > for the ORC unwinder") marked the ORC unwinder as a "reliable" unwinder.
> > > Update the help text to reflect that change: the frame pointer unwinder
> > > is no longer the only one that provides HAVE_RELIABLE_STACKTRACE.
> > > 
> > > Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> > > ---
> > >   arch/x86/Kconfig.debug | 8 ++++----
> > >   1 file changed, 4 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
> > > index bf9cd83de777..69cdf0558c13 100644
> > > --- a/arch/x86/Kconfig.debug
> > > +++ b/arch/x86/Kconfig.debug
> > > @@ -316,10 +316,6 @@ config UNWINDER_FRAME_POINTER
> > >   	  unwinder, but the kernel text size will grow by ~3% and the kernel's
> > >   	  overall performance will degrade by roughly 5-10%.
> > > -	  This option is recommended if you want to use the livepatch
> > > -	  consistency model, as this is currently the only way to get a
> > > -	  reliable stack trace (CONFIG_HAVE_RELIABLE_STACKTRACE).
> > > -
> > >   config UNWINDER_GUESS
> > >   	bool "Guess unwinder"
> > >   	depends on EXPERT
> > > @@ -333,6 +329,10 @@ config UNWINDER_GUESS
> > >   	  useful in many cases.  Unlike the other unwinders, it has no runtime
> > >   	  overhead.
> > > +	  This option is not recommended if you want to use the livepatch
> > > +	  consistency model, as this unwinder cannot guarantee reliable stack
> > > +	  traces.
> > > +
> > 
> > I'm not sure whether this last hunk is helpful.  At the very least the
> > wording of "not recommended" might be confusing because it's not even
> > possible to combine UNWINDER_GUESS+HAVE_RELIABLE_STACKTRACE.
> > 
> > arch/x86/Kconfig:       select HAVE_RELIABLE_STACKTRACE         if X86_64 && (UNWINDER_FRAME_POINTER || UNWINDER_ORC) && STACK_VALIDATION
> > 
> 
> Ah good point.  The alternative would be to copy the recommended note to
> both UNWINDER_FRAME_POINTER and UNWINDER_ORC, or at least remove the "only"
> phrasing.  I dunno, nobody has noticed it yet, so maybe the first hunk would
> be good enough.

The guess unwinder is listed as an expert option, so the user would have
to enable CONFIG_EXPERT to get to it.  Then if they do enable it and try
to load a livepatch, they'll get a runtime warning along with a patch
which never transitions.

And like you said, nobody has complained, so I'd say just dropping the
2nd hunk would be fine.

-- 
Josh


      reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 22:43 Joe Lawrence
2019-11-06 23:05 ` Josh Poimboeuf
2019-11-06 23:16   ` Joe Lawrence
2019-11-06 23:54     ` Josh Poimboeuf [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191106235423.hjamrggd4x3js5hm@treble \
    --to=jpoimboe@redhat.com \
    --cc=joe.lawrence@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Live-Patching Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/live-patching/0 live-patching/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 live-patching live-patching/ https://lore.kernel.org/live-patching \
		live-patching@vger.kernel.org
	public-inbox-index live-patching

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.live-patching


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git