Live-Patching Archive on lore.kernel.org
 help / color / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: linux-kernel@vger.kernel.org, live-patching@vger.kernel.org
Subject: Re: [PATCH v2] x86/stacktrace: update kconfig help text for reliable unwinders
Date: Wed, 6 Nov 2019 21:34:58 -0600
Message-ID: <20191107033458.ptvw6omypqndjt6d@treble> (raw)
In-Reply-To: <20191107032958.14034-1-joe.lawrence@redhat.com>

On Wed, Nov 06, 2019 at 10:29:58PM -0500, Joe Lawrence wrote:
> commit 6415b38bae26 ("x86/stacktrace: Enable HAVE_RELIABLE_STACKTRACE
> for the ORC unwinder") added the ORC unwinder as a "reliable" unwinder.
> Update the help text to reflect that change: the frame pointer unwinder
> is no longer the only one that can provide HAVE_RELIABLE_STACKTRACE.
> 
> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> ---
> 
> v2: dropped hunk that added unnecessary text to UNWIND_GUESS
> 
>  arch/x86/Kconfig.debug | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
> index bf9cd83de777..409c00f74e60 100644
> --- a/arch/x86/Kconfig.debug
> +++ b/arch/x86/Kconfig.debug
> @@ -316,10 +316,6 @@ config UNWINDER_FRAME_POINTER
>  	  unwinder, but the kernel text size will grow by ~3% and the kernel's
>  	  overall performance will degrade by roughly 5-10%.
>  
> -	  This option is recommended if you want to use the livepatch
> -	  consistency model, as this is currently the only way to get a
> -	  reliable stack trace (CONFIG_HAVE_RELIABLE_STACKTRACE).
> -
>  config UNWINDER_GUESS
>  	bool "Guess unwinder"
>  	depends on EXPERT
> -- 
> 2.21.0
> 

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

-- 
Josh


  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07  3:29 Joe Lawrence
2019-11-07  3:34 ` Josh Poimboeuf [this message]
2019-11-07 14:54   ` Petr Mladek
2019-11-07  8:44 ` Miroslav Benes
2019-11-07 12:23 ` Kamalesh Babulal

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191107033458.ptvw6omypqndjt6d@treble \
    --to=jpoimboe@redhat.com \
    --cc=joe.lawrence@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Live-Patching Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/live-patching/0 live-patching/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 live-patching live-patching/ https://lore.kernel.org/live-patching \
		live-patching@vger.kernel.org
	public-inbox-index live-patching

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.live-patching


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git