From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Jessica Yu <jeyu@kernel.org>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 6/7] livepatch: Remove module_disable_ro() usage
Date: Thu, 16 Apr 2020 07:10:08 -0500 [thread overview]
Message-ID: <20200416121008.i5vmafqcv4ab7van@treble> (raw)
In-Reply-To: <alpine.LSU.2.21.2004161126540.10475@pobox.suse.cz>
On Thu, Apr 16, 2020 at 11:28:25AM +0200, Miroslav Benes wrote:
> If I remember correctly, text_mutex must be held whenever text is modified
> to prevent race due to the modification. It is not only about permission
> changes even though it was how it manifested itself in our case.
Yeah, that's what confused me. We went years without using text_mutex
and then only started using it because of a race with the permissions
changes.
--
Josh
next prev parent reply other threads:[~2020-04-16 12:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 16:28 [PATCH 0/7] livepatch,module: Remove .klp.arch and module_disable_ro() Josh Poimboeuf
2020-04-14 16:28 ` [PATCH 1/7] livepatch: Apply vmlinux-specific KLP relocations early Josh Poimboeuf
2020-04-14 17:44 ` Peter Zijlstra
2020-04-14 18:01 ` Josh Poimboeuf
2020-04-14 19:31 ` Josh Poimboeuf
2020-04-15 14:30 ` Miroslav Benes
2020-04-15 16:29 ` Josh Poimboeuf
2020-04-15 14:34 ` Miroslav Benes
2020-04-15 16:30 ` Josh Poimboeuf
2020-04-14 16:28 ` [PATCH 2/7] livepatch: Remove .klp.arch Josh Poimboeuf
2020-04-15 15:18 ` Jessica Yu
2020-04-14 16:28 ` [PATCH 3/7] livepatch: Prevent module-specific KLP rela sections from referencing vmlinux symbols Josh Poimboeuf
2020-04-14 16:28 ` [PATCH 4/7] s390/module: Use s390_kernel_write() for relocations Josh Poimboeuf
2020-04-16 8:56 ` Miroslav Benes
2020-04-16 12:06 ` Josh Poimboeuf
2020-04-16 13:16 ` Josh Poimboeuf
2020-04-17 1:37 ` Josh Poimboeuf
2020-04-14 16:28 ` [PATCH 5/7] x86/module: Use text_poke() " Josh Poimboeuf
2020-04-14 16:28 ` [PATCH 6/7] livepatch: Remove module_disable_ro() usage Josh Poimboeuf
2020-04-15 15:02 ` Jessica Yu
2020-04-15 16:33 ` Josh Poimboeuf
2020-04-16 9:28 ` Miroslav Benes
2020-04-16 12:10 ` Josh Poimboeuf [this message]
2020-04-14 16:28 ` [PATCH 7/7] module: Remove module_disable_ro() Josh Poimboeuf
2020-04-14 18:27 ` [PATCH 0/7] livepatch,module: Remove .klp.arch and module_disable_ro() Peter Zijlstra
2020-04-14 19:08 ` Josh Poimboeuf
2020-04-15 14:24 ` Peter Zijlstra
2020-04-15 16:17 ` Josh Poimboeuf
2020-04-16 15:31 ` Jessica Yu
2020-04-16 15:45 ` Josh Poimboeuf
2020-04-17 8:27 ` Miroslav Benes
2020-04-17 8:50 ` Jessica Yu
2020-04-16 9:45 ` Miroslav Benes
2020-04-16 12:20 ` Josh Poimboeuf
2020-04-17 9:08 ` Miroslav Benes
2020-04-15 0:57 ` Joe Lawrence
2020-04-15 1:31 ` Josh Poimboeuf
2020-04-15 1:37 ` Joe Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416121008.i5vmafqcv4ab7van@treble \
--to=jpoimboe@redhat.com \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).