From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB5F9C8300A for ; Thu, 30 Apr 2020 12:23:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 965CC207DD for ; Thu, 30 Apr 2020 12:23:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588249407; bh=s+u4WbOI6jCW0oIE7DyFq3VAR+Yi4wx9kBa1D0/SdQg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=L+sN7DIFQ+kpj0Y6w40q2w9BpjPPEtcz7fcoDVODWBARnSk8w53E727PK26PWFv/V /m1TJVAwfGy19gzQVfC3NPhuGd8/+JxfY8hNJzjjRbrkcO6NH0ViDuDwR1o2k5kyIe Q/X8Kj4m0dK1JhERuqL62tu3PEc2CuNgbgxwNAQw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726520AbgD3MX1 (ORCPT ); Thu, 30 Apr 2020 08:23:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:57980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726500AbgD3MX1 (ORCPT ); Thu, 30 Apr 2020 08:23:27 -0400 Received: from linux-8ccs.fritz.box (p3EE2CE96.dip0.t-ipconnect.de [62.226.206.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7DE382076D; Thu, 30 Apr 2020 12:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588249406; bh=s+u4WbOI6jCW0oIE7DyFq3VAR+Yi4wx9kBa1D0/SdQg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mhgOxvO5SzP0qyFjlsPvJqJqqlCQC1gkhUSEE3PFUKNYiTehOjao3zPe8AbRfqp1p uJiP7AjcSpDq+dUZMmPVdH79vT+q5tiO7b+IbSfVTv+dC5g7SI3LJy21McqaopMJt4 sDh98PHeCpSs7Vvx+ngCX2xBesWFf71Lv+vwgw+c= Date: Thu, 30 Apr 2020 14:23:22 +0200 From: Jessica Yu To: Miroslav Benes Cc: Josh Poimboeuf , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Joe Lawrence Subject: Re: [PATCH v4 11/11] module: Make module_enable_ro() static again Message-ID: <20200430122321.GA16620@linux-8ccs.fritz.box> References: <20200430111032.GA4436@linux-8ccs> <20200430114055.GA15426@linux-8ccs.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200430114055.GA15426@linux-8ccs.fritz.box> X-OS: Linux linux-8ccs 4.12.14-lp150.12.61-default x86_64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: live-patching-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org +++ Jessica Yu [30/04/20 13:40 +0200]: >+++ Miroslav Benes [30/04/20 13:35 +0200]: >>On Thu, 30 Apr 2020, Jessica Yu wrote: >> >>>+++ Josh Poimboeuf [29/04/20 10:24 -0500]: >>>>Now that module_enable_ro() has no more external users, make it static >>>>again. >>>> >>>>Suggested-by: Jessica Yu >>>>Signed-off-by: Josh Poimboeuf >>> >>>Thanks! Since this patch is separate from the rest and it's based on >>>modules-next, I can just take this last patch through the modules tree. >> >>It depends on 8/11 of the series. >> >>Acked-by: Miroslav Benes >> >>for the patch. > >Ah yeah, you are right (you meant patch 9/11 right)? Will take both >through modules-next. So I'm speaking nonsense apparently. I suggested taking them because the module patches were based on modules-next. But Miroslav correctly pointed out that these patches still depend on livepatch removing module_disable_ro() usage before we can even remove them from module.c. So ignore what I said earlier, the whole patchset should be applied together (I'm assuming the livepatching for-next branch). In any case, should there be any conflicts with modules-next they should be easy to resolve. Sorry for the noise! Jessica