From: Josh Poimboeuf <jpoimboe@redhat.com>
To: "Wangshaobo (bobo)" <bobo.shaobowang@huawei.com>
Cc: huawei.libin@huawei.com, xiexiuqi@huawei.com,
cj.chengjian@huawei.com, mingo@redhat.com, x86@kernel.org,
linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
mbenes@suse.cz, devel@etsukata.com, viro@zeniv.linux.org.uk,
esyr@redhat.com
Subject: Re: Question: livepatch failed for new fork() task stack unreliable
Date: Mon, 1 Jun 2020 13:05:38 -0500 [thread overview]
Message-ID: <20200601180538.o5agg5trbdssqken@treble> (raw)
In-Reply-To: <a9ed9157-f3cf-7d2c-7a8e-56150a2a114e@huawei.com>
On Sat, May 30, 2020 at 10:21:19AM +0800, Wangshaobo (bobo) wrote:
> 1) when a user mode task just fork start excuting ret_from_fork() till
> schedule_tail, unwind_next_frame found
>
> orc->sp_reg is ORC_REG_UNDEFINED but orc->end not equals zero, this time
> arch_stack_walk_reliable()
>
> terminates it's backtracing loop for unwind_done() return true. then 'if
> (!(task->flags & (PF_KTHREAD | PF_IDLE)))'
>
> in arch_stack_walk_reliable() true and return -EINVAL after.
>
> * The stack trace looks like that:
>
> ret_from_fork
>
> -=> UNWIND_HINT_EMPTY
>
> -=> schedule_tail /* schedule out */
>
> ...
>
> -=> UNWIND_HINT_REGS /* UNDO */
Yes, makes sense.
> 2) when using call_usermodehelper_exec_async() to create a user mode task,
> ret_from_fork() still not exec whereas
>
> the task has been scheduled in __schedule(), at this time, orc->sp_reg is
> ORC_REG_UNDEFINED but orc->end equals zero,
>
> unwind_error() return true and also terminates arch_stack_walk_reliable()'s
> backtracing loop, end up return from
>
> 'if (unwind_error())' branch.
>
> * The stack trace looks like that:
>
> -=> call_usermodehelper_exec
>
> -=> do_exec
>
> -=> search_binary_handler
>
> -=> load_elf_binary
>
> -=> elf_map
>
> -=> vm_mmap_pgoff
>
> -=> down_write_killable
>
> -=> _cond_resched
>
> -=> __schedule /* scheduled to work */
>
> -=> ret_from_fork /* UNDO */
I don't quite follow the stacktrace, but it sounds like the issue is the
same as the first one you originally reported:
> 1) The task was not actually scheduled to excute, at this time
> UNWIND_HINT_EMPTY in ret_from_fork() has not reset unwind_hint, it's
> sp_reg and end field remain default value and end up throwing an error
> in unwind_next_frame() when called by arch_stack_walk_reliable();
Or am I misunderstanding?
And to reiterate, these are not "livepatch failures", right? Livepatch
doesn't fail when stack_trace_save_tsk_reliable() returns an error. It
recovers gracefully and tries again later.
--
Josh
next prev parent reply other threads:[~2020-06-01 18:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 10:10 Question: livepatch failed for new fork() task stack unreliable Wang ShaoBo
2020-05-29 17:44 ` Josh Poimboeuf
[not found] ` <a9ed9157-f3cf-7d2c-7a8e-56150a2a114e@huawei.com>
2020-06-01 18:05 ` Josh Poimboeuf [this message]
2020-06-02 1:22 ` Wangshaobo (bobo)
2020-06-02 13:14 ` Josh Poimboeuf
2020-06-03 14:06 ` Wangshaobo (bobo)
2020-06-03 15:33 ` Josh Poimboeuf
2020-06-04 1:24 ` Wangshaobo (bobo)
2020-06-04 2:40 ` Josh Poimboeuf
2020-06-05 1:26 ` Wangshaobo (bobo)
2020-06-05 1:51 ` Josh Poimboeuf
2020-06-30 13:04 ` Wangshaobo (bobo)
2020-06-30 21:36 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601180538.o5agg5trbdssqken@treble \
--to=jpoimboe@redhat.com \
--cc=bobo.shaobowang@huawei.com \
--cc=cj.chengjian@huawei.com \
--cc=devel@etsukata.com \
--cc=esyr@redhat.com \
--cc=huawei.libin@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).